[
https://issues.apache.org/jira/browse/BEAM-10937?focusedWorklogId=587578&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587578
]
ASF GitHub Bot logged work on BEAM-10937:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Apr/21 00:35
Start Date: 23/Apr/21 00:35
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #14431:
URL: https://github.com/apache/beam/pull/14431#discussion_r618840227
##########
File path: examples/notebooks/tour-of-beam/reading-and-writing-data.ipynb
##########
@@ -606,32 +657,31 @@
" def teardown(self):\n",
" self.connection.close()\n",
"\n",
- "class SelectFromSQLite(beam.PTransform):\n",
- " def __init__(self, database_file, queries):\n",
- " self.database_file = database_file\n",
- " self.queries = queries\n",
- "\n",
- " def expand(self, pcollection):\n",
- " return (\n",
- " pcollection\n",
- " | 'Create None' >> beam.Create(queries)\n",
- " | 'SQLite SELECT' >>
beam.ParDo(SQLiteSelect(self.database_file))\n",
- " )\n",
+ "@beam.ptransform_fn\n",
+ "@beam.typehints.with_input_types(beam.pvalue.PBegin)\n",
+ "@beam.typehints.with_output_types(Dict[str, str])\n",
+ "def SelectFromSQLite(pcollection, database_file: str, queries:
List[Tuple[str, List[str]]]):\n",
Review comment:
same here and below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 587578)
Time Spent: 10h (was: 9h 50m)
> Create "Tour of Beam" introductory section
> ------------------------------------------
>
> Key: BEAM-10937
> URL: https://issues.apache.org/jira/browse/BEAM-10937
> Project: Beam
> Issue Type: Improvement
> Components: website
> Reporter: David Cavazos
> Priority: P3
> Time Spent: 10h
> Remaining Estimate: 0h
>
> Create a new "Tour of Beam" section in the docs, with links to all the
> notebooks we have to improve the onboarding experience for beginners.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
