[
https://issues.apache.org/jira/browse/BEAM-12093?focusedWorklogId=587722&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587722
]
ASF GitHub Bot logged work on BEAM-12093:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Apr/21 09:18
Start Date: 23/Apr/21 09:18
Worklog Time Spent: 10m
Work Description: echauchot commented on pull request #14347:
URL: https://github.com/apache/beam/pull/14347#issuecomment-825523777
> Thanks for the 2nd round @echauchot ! Working my way through your comments
and adding test coverage. Seeing some of behaviour in the tests, I may have to
reach out with questions if I can’t get to the bottom of it.
>
> Somewhat related: can you describe the high-level difference between the
IOTest Vs. IOIT files?
UTests for IO are not in the proper sense UTests because they depend on
external software (embedded in-jvm ES instance provided by elastic test
framework). We do so because to be relevant, the tests need to be run against a
real backend and not a mock. And we want to fail the build if any regression
occurs.
ITests are run against elasticsearch instances installed in a cluster in IT
environment. The tests there are more aimed for volume (which as proved to be a
problem in some cases).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 587722)
Time Spent: 6.5h (was: 6h 20m)
> Overhaul ElasticsearchIO#Write
> ------------------------------
>
> Key: BEAM-12093
> URL: https://issues.apache.org/jira/browse/BEAM-12093
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Evan Galpin
> Priority: P2
> Labels: elasticsearch
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> The current ElasticsearchIO#Write is great, but there are two related areas
> which could be improved:
> # Separation of concern
> # Bulk API batch size optimization
>
> Presently, the Write transform has 2 responsibilities which are coupled and
> inseparable by users:
> # Convert input documents into Bulk API entities, serializing based on user
> settings (partial update, delete, upsert, etc)
> # Batch the converted Bulk API entities together and interface with the
> target ES cluster
>
> Having these 2 roles tightly coupled means testing requires an available
> Elasticsearch cluster, making unit testing almost impossible. Allowing access
> to the serialized documents would make unit testing much easier for pipeline
> developers, among numerous other benefits to having separation between
> serialization and IO.
> Relatedly, the batching of entities when creating Bulk API payloads is
> currently limited by the lesser of Beam Runner bundling semantics, and the
> `ElasticsearchIO#Write#maxBatchSize` setting. This is understandable for
> portability between runners, but it also means most Bulk payloads only have a
> few (1-5) entities. By using Stateful Processing to better adhere to the
> `ElasticsearchIO#Write#maxBatchSize` setting, we have been able to drop the
> number of indexing requests in an Elasticsearch cluster by 50-100x.
> Separating the role of document serialization and IO allows supporting
> multiple IO techniques with minimal and understandable code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
