[
https://issues.apache.org/jira/browse/BEAM-11010?focusedWorklogId=587932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587932
]
ASF GitHub Bot logged work on BEAM-11010:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Apr/21 15:54
Start Date: 23/Apr/21 15:54
Worklog Time Spent: 10m
Work Description: suztomo commented on a change in pull request #14578:
URL: https://github.com/apache/beam/pull/14578#discussion_r619328009
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/SubscriberOptions.java
##########
@@ -86,11 +107,31 @@
public static Builder newBuilder() {
Builder builder = new AutoValue_SubscriberOptions.Builder();
- return
builder.setPartitions(ImmutableSet.of()).setFlowControlSettings(DEFAULT_FLOW_CONTROL);
+ return builder
+ .setPartitions(ImmutableSet.of())
+ .setFlowControlSettings(DEFAULT_FLOW_CONTROL)
+ .setMinBundleTimeout(MIN_BUNDLE_TIMEOUT);
}
public abstract Builder toBuilder();
+ private SubscriberServiceClient newSubscriberServiceClient(Partition
partition)
+ throws ApiException {
+ try {
+ SubscriberServiceSettings.Builder settingsBuilder =
SubscriberServiceSettings.newBuilder();
+
+ settingsBuilder =
+ addDefaultMetadata(
+ PubsubContext.of(FRAMEWORK),
+ RoutingMetadata.of(subscriptionPath(), partition),
+ settingsBuilder);
Review comment:
Memo: This assignment to `settingsBuilder` is unnecessary, but without
that error prone gives error for ignoring the return value of the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 587932)
Time Spent: 12h 50m (was: 12h 40m)
> Beam Dependency Update Request: com.google.cloud:google-cloud-pubsublite
> ------------------------------------------------------------------------
>
> Key: BEAM-11010
> URL: https://issues.apache.org/jira/browse/BEAM-11010
> Project: Beam
> Issue Type: Sub-task
> Components: dependencies
> Reporter: Beam JIRA Bot
> Assignee: Tomo Suzuki
> Priority: P3
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
> ------------------------- 2020-10-05 12:16:22.002680
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.1.6. The latest version is 0.4.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2020-10-12 12:17:32.946707
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.1.6. The latest version is 0.4.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-02-08 12:24:12.051486
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.10.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-02-15 12:22:21.398946
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.10.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-02-22 12:20:02.544703
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.10.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-01 12:20:42.879270
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.11.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-08 12:22:30.221914
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.11.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-15 12:24:04.931272
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.11.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-22 12:21:36.885299
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.12.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-03-29 12:21:24.103712
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.12.0
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-04-05 12:22:46.599190
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.13.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-04-12 12:24:00.148493
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.13.1
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
> ------------------------- 2021-04-19 12:22:29.948524
> -------------------------
> Please consider upgrading the dependency
> com.google.cloud:google-cloud-pubsublite.
> The current version is 0.7.0. The latest version is 0.13.2
> cc:
> Please refer to [Beam Dependency Guide
> |https://beam.apache.org/contribute/dependencies/]for more information.
> Do Not Modify The Description Above.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
