[
https://issues.apache.org/jira/browse/BEAM-3713?focusedWorklogId=589320&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-589320
]
ASF GitHub Bot logged work on BEAM-3713:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/21 16:00
Start Date: 26/Apr/21 16:00
Worklog Time Spent: 10m
Work Description: benWize commented on a change in pull request #14481:
URL: https://github.com/apache/beam/pull/14481#discussion_r620435599
##########
File path: sdks/python/scripts/run_integration_test.sh
##########
@@ -270,11 +281,24 @@ fi
# Run tests and validate that jobs finish successfully.
echo ">>> RUNNING integration tests with pipeline options: $PIPELINE_OPTS"
-echo ">>> test options: $TEST_OPTS"
-# TODO(BEAM-3713): Pass $SUITE once migrated to pytest. xunitmp doesn't support
-# suite names.
-python setup.py nosetests \
- --test-pipeline-options="$PIPELINE_OPTS" \
- --with-xunitmp --xunitmp-file=$XUNIT_FILE \
- --ignore-files '.*py3\d?\.py$' \
- $TEST_OPTS
+if [[ "$PYTEST" = true ]]; then
+ echo ">>> pytest options: $TEST_OPTS"
+ ARGS="-o junit_suite_name=$SUITE --junitxml=pytest_$SUITE.xml $TEST_OPTS"
+# Handle markers as an independient argument from $TEST_OPTS to prevent
errors in space separeted flags
Review comment:
Fixed!
##########
File path: sdks/python/scripts/run_integration_test.sh
##########
@@ -270,11 +281,24 @@ fi
# Run tests and validate that jobs finish successfully.
echo ">>> RUNNING integration tests with pipeline options: $PIPELINE_OPTS"
-echo ">>> test options: $TEST_OPTS"
-# TODO(BEAM-3713): Pass $SUITE once migrated to pytest. xunitmp doesn't support
-# suite names.
-python setup.py nosetests \
- --test-pipeline-options="$PIPELINE_OPTS" \
- --with-xunitmp --xunitmp-file=$XUNIT_FILE \
- --ignore-files '.*py3\d?\.py$' \
- $TEST_OPTS
+if [[ "$PYTEST" = true ]]; then
+ echo ">>> pytest options: $TEST_OPTS"
Review comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 589320)
Time Spent: 29h 50m (was: 29h 40m)
> Consider moving away from nose to nose2 or pytest.
> --------------------------------------------------
>
> Key: BEAM-3713
> URL: https://issues.apache.org/jira/browse/BEAM-3713
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core, testing
> Reporter: Robert Bradshaw
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 29h 50m
> Remaining Estimate: 0h
>
> Per
> [https://nose.readthedocs.io/en/latest/|https://nose.readthedocs.io/en/latest/,]
> , nose is in maintenance mode.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
