[
https://issues.apache.org/jira/browse/BEAM-12140?focusedWorklogId=589543&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-589543
]
ASF GitHub Bot logged work on BEAM-12140:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/21 03:33
Start Date: 27/Apr/21 03:33
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#14491:
URL: https://github.com/apache/beam/pull/14491#discussion_r620825771
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -588,11 +588,25 @@ def _stage_resources(self, pipeline, options):
'Found duplicated artifact: %s (%s)',
type_payload.path,
type_payload.sha256)
+ staged_name = hashs[type_payload.sha256]
dep.role_payload = beam_runner_api_pb2.ArtifactStagingToRolePayload(
- staged_name=hashs[type_payload.sha256]).SerializeToString()
+ staged_name=staged_name).SerializeToString()
else:
- resources.append((type_payload.path, role_payload.staged_name))
- hashs[type_payload.sha256] = role_payload.staged_name
+ staged_name = role_payload.staged_name
+ resources.append((type_payload.path, staged_name))
+ hashs[type_payload.sha256] = staged_name
+
+ if google_cloud_options.staging_location.startswith('gs://'):
Review comment:
Is this check needed ? I think Dataflow staging location always has to
be a GCS path.
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -588,11 +588,25 @@ def _stage_resources(self, pipeline, options):
'Found duplicated artifact: %s (%s)',
type_payload.path,
type_payload.sha256)
+ staged_name = hashs[type_payload.sha256]
dep.role_payload = beam_runner_api_pb2.ArtifactStagingToRolePayload(
- staged_name=hashs[type_payload.sha256]).SerializeToString()
+ staged_name=staged_name).SerializeToString()
else:
- resources.append((type_payload.path, role_payload.staged_name))
- hashs[type_payload.sha256] = role_payload.staged_name
+ staged_name = role_payload.staged_name
+ resources.append((type_payload.path, staged_name))
+ hashs[type_payload.sha256] = staged_name
+
+ if google_cloud_options.staging_location.startswith('gs://'):
+ dep.type_urn = common_urns.artifact_types.URL.urn
+ dep.type_payload = beam_runner_api_pb2.ArtifactUrlPayload(
+ url=FileSystems.join(
+ google_cloud_options.staging_location,
+ staged_name)).SerializeToString()
+ else:
+ dep.type_payload = beam_runner_api_pb2.ArtifactFilePayload(
Review comment:
Can you clarify when a Dataflow pipeline will use "ArtifactFilePayload"
instead of "ArtifactUrlPayload" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 589543)
Time Spent: 2h 10m (was: 2h)
> Update artifact information when staging artifacts to gcs for Dataflow
> ----------------------------------------------------------------------
>
> Key: BEAM-12140
> URL: https://issues.apache.org/jira/browse/BEAM-12140
> Project: Beam
> Issue Type: Improvement
> Components: cross-language, runner-dataflow
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Update artifact information when staging artifacts to gcs for Dataflow
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
