[jira] [Updated] (BEAM-12173) Avoid intermediate conversion to seconds in BigQueryServicesImpl

[Alexey Romanenko (Jira)]

     [ 
https://issues.apache.org/jira/browse/BEAM-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexey Romanenko updated BEAM-12173:
------------------------------------
    Description: 
In 
[BigQueryServicesImpl.java|https://github.com/apache/beam/blob/4b7b74673b647c8d964b4877a8d66d47096acce4/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java]
 avoid a conversion:

{{TimeUnit.MILLISECONDS.toSeconds(RETRY_CREATE_TABLE_DURATION_MILLIS) / 60.0);}}

Instead use just
{{TimeUnit.MILLISECONDS.toMinutes(RETRY_CREATE_TABLE_DURATION_MILLIS));}}

  was:
in
h2. 
[beam|https://github.com/apache/beam/tree/4b7b74673b647c8d964b4877a8d66d47096acce4]/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/*BigQueryServicesImpl.java*

 

TimeUnit.MILLISECONDS.toSeconds(RETRY_CREATE_TABLE_DURATION_MILLIS) / 60.0);

-->

 

TimeUnit.MILLISECONDS.toMinutes(RETRY_CREATE_TABLE_DURATION_MILLIS));


> Avoid intermediate conversion to seconds in BigQueryServicesImpl
> ----------------------------------------------------------------
>
>                 Key: BEAM-12173
>                 URL: https://issues.apache.org/jira/browse/BEAM-12173
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-gcp
>            Reporter: Elliotte Rusty Harold
>            Priority: P4
>             Fix For: 2.30.0
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> In 
> [BigQueryServicesImpl.java|https://github.com/apache/beam/blob/4b7b74673b647c8d964b4877a8d66d47096acce4/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java]
>  avoid a conversion:
> {{TimeUnit.MILLISECONDS.toSeconds(RETRY_CREATE_TABLE_DURATION_MILLIS) / 
> 60.0);}}
> Instead use just
> {{TimeUnit.MILLISECONDS.toMinutes(RETRY_CREATE_TABLE_DURATION_MILLIS));}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)