[
https://issues.apache.org/jira/browse/BEAM-12165?focusedWorklogId=589858&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-589858
]
ASF GitHub Bot logged work on BEAM-12165:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/21 16:33
Start Date: 27/Apr/21 16:33
Worklog Time Spent: 10m
Work Description: ernvalentino commented on a change in pull request
#14644:
URL: https://github.com/apache/beam/pull/14644#discussion_r621393777
##########
File path:
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##########
@@ -1154,6 +1154,8 @@ public static Sink sink(Schema schema) {
abstract int getRowGroupSize();
+ abstract @Nullable Class<? extends GenericData> getAvroDataModel();
Review comment:
it needs to be serializable, since this is passed to the `DoFn`
responsible for writing. The reader does the same way in the
[`ReadFn`](https://github.com/apache/beam/blob/master/sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java#L1069)
and
[`SplitReadFn`](https://github.com/apache/beam/blob/master/sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java#L810)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 589858)
Time Spent: 1.5h (was: 1h 20m)
> ParquetIO sink should allow to pass an Avro data model
> ------------------------------------------------------
>
> Key: BEAM-12165
> URL: https://issues.apache.org/jira/browse/BEAM-12165
> Project: Beam
> Issue Type: Bug
> Components: io-java-parquet
> Reporter: Ning Kang
> Assignee: Ernesto Valentino
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> AvroParquetWriter instantiated in ParquetIO [1] does not specify the data
> model.
> The default is SpecificData model [2], while the AvroParquetReader is reading
> with a GenericData model [3].
> ParquetIO should pass in the correct data model.
> [1]
> https://github.com/apache/beam/blob/v2.28.0/sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java#L1052
> [2]
> https://github.com/apache/parquet-mr/blob/master/parquet-avro/src/main/java/org/apache/parquet/avro/AvroParquetWriter.java#L163
> [3]
> https://github.com/apache/beam/blob/v2.28.0/sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java#L704
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
