[
https://issues.apache.org/jira/browse/BEAM-2085?focusedWorklogId=590005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-590005
]
ASF GitHub Bot logged work on BEAM-2085:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/21 19:53
Start Date: 27/Apr/21 19:53
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #14607:
URL: https://github.com/apache/beam/pull/14607#discussion_r621553275
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
##########
@@ -760,6 +776,24 @@ private void addDisplayData(Step step, String stepName,
HasDisplayData hasDispla
List<Map<String, Object>> list = MAPPER.convertValue(displayData,
List.class);
addList(getProperties(), PropertyNames.DISPLAY_DATA, list);
}
+
+ private void addResourceHints(Step step, String stepName, ResourceHints
hints) {
+ Map<String, Object> urlEncodedHints = new HashMap<>();
+ PercentCodec codec = new PercentCodec();
+ for (Entry<String, ResourceHint> entry : hints.hints().entrySet()) {
+ try {
Review comment:
It doesn't seem to be new for Beam,
https://github.com/apache/beam/blob/8b7f0b994926981298eb8195b2af24c8f12cebee/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L500,
but I had to declare it a compile-time dep for dataflow runner module. It is
small (400kb jar) and unlikely cause versioning conflicts.
One thought is that if we ever get to have binary-valued hints, encoding
bytes directly will be easier. I notice though PercentCodec does not by default
encode '+' as '%2b', but I can configure that to be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 590005)
Time Spent: 38.5h (was: 38h 20m)
> Transforms could give hints to runners on resource requirements
> ---------------------------------------------------------------
>
> Key: BEAM-2085
> URL: https://issues.apache.org/jira/browse/BEAM-2085
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, runner-core, sdk-java-core
> Affects Versions: Not applicable
> Reporter: Ismaël Mejía
> Assignee: Valentyn Tymofieiev
> Priority: P3
> Labels: Clarified
> Time Spent: 38.5h
> Remaining Estimate: 0h
>
> As discussed in BEAM-673 runners can allocate workers to accomplish their
> work in a better way if they can take into account some hints from the
> transforms, e.g. a source can hint data locality and with this information
> the runner can allocate the workers in an better way, this can also be the
> case with a particular transform that can suggest to the runner to be
> executed in a worker with a specific resource, e.g. GPU.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
