[
https://issues.apache.org/jira/browse/BEAM-4076?focusedWorklogId=201447&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201447
]
ASF GitHub Bot logged work on BEAM-4076:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/19 17:05
Start Date: 20/Feb/19 17:05
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7635:
[BEAM-4076] Generalize schema inputs to ParDo
URL: https://github.com/apache/beam/pull/7635#discussion_r258582744
##########
File path:
runners/apex/src/main/java/org/apache/beam/runners/apex/translation/ParDoTranslator.java
##########
@@ -77,6 +80,13 @@ public void translate(ParDo.MultiOutput<InputT, OutputT>
transform, TranslationC
PCollection<InputT> input = context.getInput();
List<PCollectionView<?>> sideInputs = transform.getSideInputs();
+ DoFnSchemaInformation doFnSchemaInformation;
+ try {
+ doFnSchemaInformation =
ParDoTranslation.getSchemaInformation(context.getCurrentTransform());
+ } catch (IOException e) {
Review comment:
This exception handling is duplicated all over. Should it be moved into
`getSchemaInformation`? When does the IOException get raised? Is there any
value in forcing callers to handle it? If you wouldn't make
`getSchemaInformation` return a `oneof` then it shouldn't throw a checked
exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 201447)
Time Spent: 19h 40m (was: 19.5h)
> Schema followups
> ----------------
>
> Key: BEAM-4076
> URL: https://issues.apache.org/jira/browse/BEAM-4076
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, dsl-sql, sdk-java-core
> Reporter: Kenneth Knowles
> Priority: Major
> Time Spent: 19h 40m
> Remaining Estimate: 0h
>
> This umbrella bug contains subtasks with followups for Beam schemas, which
> were moved from SQL to the core Java SDK and made to be type-name-based
> rather than coder based.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
