[
https://issues.apache.org/jira/browse/BEAM-11719?focusedWorklogId=591726&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591726
]
ASF GitHub Bot logged work on BEAM-11719:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Apr/21 21:47
Start Date: 30/Apr/21 21:47
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #14680:
URL: https://github.com/apache/beam/pull/14680#discussion_r624233543
##########
File path: sdks/python/apache_beam/coders/coders_test_common.py
##########
@@ -236,6 +252,13 @@ def test_deterministic_coder(self):
self.check_coder(deterministic_coder, list(MyIntFlag))
self.check_coder(deterministic_coder, list(MyFlag))
+ self.check_coder(
+ deterministic_coder,
+ [DefinesGetAndSetState(1), DefinesGetAndSetState((1, 2, 3))])
+
+ with self.assertRaises(TypeError):
Review comment:
Also add a check of trying to use this for a non-deterministic state?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 591726)
Time Spent: 13h 10m (was: 13h)
> Enforce deterministic coding for GroupByKey and Stateful DoFns
> --------------------------------------------------------------
>
> Key: BEAM-11719
> URL: https://issues.apache.org/jira/browse/BEAM-11719
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: P1
> Fix For: 2.29.0
>
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> If a non-deterministic coder, such as pickling, is used for keys this can
> result in two copies of the same key being grouped separately (based on their
> encodings).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
