[
https://issues.apache.org/jira/browse/BEAM-6720?focusedWorklogId=201663&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201663
]
ASF GitHub Bot logged work on BEAM-6720:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/19 22:42
Start Date: 20/Feb/19 22:42
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7911:
[BEAM-6720] Add binary compatibility adapters for
ProcessFunction/InferableFunction overloads
URL: https://github.com/apache/beam/pull/7911
Because method overloads are resolved statically, 2.10.0 is compile
compatible but not binary compatible with 2.9.0.
This introduces adapters where needed to restore binary compatibility.
Testing will be by hand and one-off as I'm not sure the infrastructure that
would be needed to test these automatically.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
See [.test-infra/jenkins/README](../.test-infra/jenkins/README.md) for
trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 201663)
Time Spent: 10m
Remaining Estimate: 0h
> Binary incompatibility introduced to MapElements between 2.9.0 and 2.10.0
> -------------------------------------------------------------------------
>
> Key: BEAM-6720
> URL: https://issues.apache.org/jira/browse/BEAM-6720
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.10.0
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Blocker
> Fix For: 2.11.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7160
> {{MapElements.via(SimpleFunction)}} was removed and replaced with
> {{MapElements.via(InferableFunction)}}.
> This is compatible with a recompile, but loses binary compatibility because
> the needed method signature is missing. I believe a pass-through method with
> the needed signature can be added to restore binary compatibility.
> CC [[email protected]] [~altay]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
