[
https://issues.apache.org/jira/browse/BEAM-12266?focusedWorklogId=593571&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-593571
]
ASF GitHub Bot logged work on BEAM-12266:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/May/21 22:11
Start Date: 07/May/21 22:11
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #14531:
URL: https://github.com/apache/beam/pull/14531#discussion_r628567821
##########
File path:
examples/java/src/test/java/org/apache/beam/examples/complete/twitterstreamgenerator/ReadFromTwitterDoFnTest.java
##########
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.examples.complete.twitterstreamgenerator;
+
+public class ReadFromTwitterDoFnTest {}
Review comment:
Please add a couple tests if possible. Thanks!
##########
File path:
examples/java/src/main/java/org/apache/beam/examples/complete/twitterstreamgenerator/TwitterIO.java
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.examples.complete.twitterstreamgenerator;
+
+import java.util.ArrayList;
+import java.util.List;
+import org.apache.beam.sdk.transforms.Create;
+import org.apache.beam.sdk.transforms.PTransform;
+import org.apache.beam.sdk.transforms.ParDo;
+import org.apache.beam.sdk.values.PBegin;
+import org.apache.beam.sdk.values.PCollection;
+import twitter4j.Status;
+
+/**
+ * An unbounded source for <a
+ *
href="https://developer.twitter.com/en/docs/tutorials/consuming-streaming-data";>twitter</a>
+ * stream.
Review comment:
Can you add an example of usage on the Javadoc?
##########
File path:
examples/java/src/main/java/org/apache/beam/examples/complete/twitterstreamgenerator/README.md
##########
@@ -0,0 +1,41 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Twitter Connector
+
+This directory contains an example pipelines for how to perform continues
stream of data from twitter streaming api ( or any other 3rd party API ). This
include:
+
+<ul>
+ <li><a
href="https://javadoc.io/static/org.apache.beam/beam-sdks-java-core/2.14.0/org/apache/beam/sdk/transforms/DoFn.ProcessElement.html";>Splitable
Dofn</a>
Review comment:
```suggestion
<li><a
href="https://javadoc.io/static/org.apache.beam/beam-sdks-java-core/current/org/apache/beam/sdk/transforms/DoFn.ProcessElement.html";>Splitable
Dofn</a>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 593571)
Remaining Estimate: 503h 50m (was: 504h)
Time Spent: 10m
> Add an example for consuming standard twitter streams live
> ----------------------------------------------------------
>
> Key: BEAM-12266
> URL: https://issues.apache.org/jira/browse/BEAM-12266
> Project: Beam
> Issue Type: Wish
> Components: examples-java
> Affects Versions: 2.28.0
> Reporter: Uday Singh
> Assignee: Uday Singh
> Priority: P2
> Labels: newbie
> Fix For: Not applicable
>
> Original Estimate: 504h
> Time Spent: 10m
> Remaining Estimate: 503h 50m
>
> We want to have a standard Twitter stream connecter that could fetch live
> data off Twitter and consume it in a lifetime. This is a good contender for
> an example.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
