[ 
https://issues.apache.org/jira/browse/BEAM-9487?focusedWorklogId=594673&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-594673
 ]

ASF GitHub Bot logged work on BEAM-9487:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/May/21 18:37
            Start Date: 11/May/21 18:37
    Worklog Time Spent: 10m 
      Work Description: zhoufek commented on pull request #14780:
URL: https://github.com/apache/beam/pull/14780#issuecomment-838972122


   Feeling a bit silly: Something I didn't try was just setting the 
PCollections to be bounded. I don't think it should be too dangerous here, 
since the intent is to materialize the data for checking, effectively making 
this PCollection bound to the current data. Anyways, it fixes all the tests 
that were failing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 594673)
    Time Spent: 0.5h  (was: 20m)

> GBKs on unbounded pcolls with global windows and no triggers should fail
> ------------------------------------------------------------------------
>
>                 Key: BEAM-9487
>                 URL: https://issues.apache.org/jira/browse/BEAM-9487
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Udi Meiri
>            Assignee: Zachary Houfek
>            Priority: P2
>              Labels: EaseOfUse, starter
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This, according to "4.2.2.1 GroupByKey and unbounded PCollections" in 
> https://beam.apache.org/documentation/programming-guide/.
> bq. If you do apply GroupByKey or CoGroupByKey to a group of unbounded 
> PCollections without setting either a non-global windowing strategy, a 
> trigger strategy, or both for each collection, Beam generates an 
> IllegalStateException error at pipeline construction time.
> Example where this doesn't happen in Python SDK: 
> https://stackoverflow.com/questions/60623246/merge-pcollection-with-apache-beam
> I also believe that this unit test should fail, since test_stream is 
> unbounded, uses global window, and has no triggers.
> {code}
>   def test_global_window_gbk_fail(self):
>     with TestPipeline() as p:
>       test_stream = TestStream()
>       _ = p | test_stream | GroupByKey()
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to