[
https://issues.apache.org/jira/browse/BEAM-10144?focusedWorklogId=595057&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-595057
]
ASF GitHub Bot logged work on BEAM-10144:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/May/21 04:10
Start Date: 12/May/21 04:10
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #14738:
URL: https://github.com/apache/beam/pull/14738#discussion_r630710589
##########
File path: sdks/python/apache_beam/examples/snippets/snippets_test.py
##########
@@ -600,15 +601,16 @@ def get_output(self, path, sorted_output=True, suffix=''):
def test_model_pipelines(self):
temp_path = self.create_temp_file('aa bb cc\n bb cc\n cc')
result_path = temp_path + '.result'
- snippets.model_pipelines(
- ['--input=%s*' % temp_path, '--output=%s' % result_path])
+ test_argv = [f"--input={temp_path}*", f"--output={result_path}"]
Review comment:
I believe you need to add one extra argument in test_argv.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 595057)
Time Spent: 3h 20m (was: 3h 10m)
> Update pipeline options snippets for best practices
> ---------------------------------------------------
>
> Key: BEAM-10144
> URL: https://issues.apache.org/jira/browse/BEAM-10144
> Project: Beam
> Issue Type: Improvement
> Components: examples-python
> Reporter: David Cavazos
> Priority: P3
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
