[
https://issues.apache.org/jira/browse/BEAM-12246?focusedWorklogId=595153&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-595153
]
ASF GitHub Bot logged work on BEAM-12246:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/May/21 09:19
Start Date: 12/May/21 09:19
Worklog Time Spent: 10m
Work Description: rohdesamuel commented on a change in pull request
#14778:
URL: https://github.com/apache/beam/pull/14778#discussion_r630872912
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py
##########
@@ -529,6 +534,11 @@ def collect(pcoll, n='inf', duration='inf',
include_window_info=False):
n: (optional) max number of elements to visualize. Default 'inf'.
duration: (optional) max duration of elements to read in integer seconds or
a string duration. Default 'inf'.
+ include_window_info: (optional) if True, appends the windowing information
+ to each row. Default False.
+ reset_unnamed_indexes: (optional) If True, resets unnamed indices. This is
+ useful because the Beam DataFrame model has non-deterministic index
+ values for DataFrames with unnamed indexes. Default True.
Review comment:
Yeah, check out the test_parse_dataframes method in the utils_test.py.
Without the reset_index code in the at the end of elements_to_df in utils.py,
that test will fail. Specifically, the index will be zero for each row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 595153)
Time Spent: 4h 10m (was: 4h)
> ib.collect doesn't preserve the index from DeferredDataFrame instances
> ----------------------------------------------------------------------
>
> Key: BEAM-12246
> URL: https://issues.apache.org/jira/browse/BEAM-12246
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Affects Versions: 2.29.0
> Reporter: Brian Hulette
> Assignee: Sam Rohde
> Priority: P2
> Labels: dataframe-api
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> This happens because it use {{to_pcollection(yield='schemas',
> include_indexes=False)}} (the default values for those arguments). To fix
> this we should avoid converting to beam schemas and collect the raw
> dataframes with {{to_pcollectiion(yield='pandas')}}.
> See https://github.com/apache/beam/pull/14356#discussion_r620647659
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
