[
https://issues.apache.org/jira/browse/BEAM-9547?focusedWorklogId=595646&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-595646
]
ASF GitHub Bot logged work on BEAM-9547:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/May/21 21:27
Start Date: 12/May/21 21:27
Worklog Time Spent: 10m
Work Description: rohdesamuel commented on a change in pull request
#14468:
URL: https://github.com/apache/beam/pull/14468#discussion_r631412965
##########
File path: sdks/python/apache_beam/dataframe/frames_test.py
##########
@@ -1059,6 +1059,18 @@ def test_insert(self):
lambda df: df.insert(0, 'foo', pd.Series([8], index=[1])), df)
self._run_inplace_test(lambda df: df.insert(2, 'bar', value='q'), df)
+ def test_series_agg_std(self):
+ s = pd.Series(range(10))
+
+ self._run_test(lambda s: s.agg('std'), s)
+ self._run_test(lambda s: s.agg('var'), s)
+ self._run_test(lambda s: s.agg(['std', 'sum']), s)
+ self._run_test(lambda s: s.agg(['var']), s)
+
+ def test_dataframe_std(self):
+ self._run_test(lambda df: df.std(numeric_only=True), GROUPBY_DF)
+ self._run_test(lambda df: df.var(numeric_only=True), GROUPBY_DF)
Review comment:
Can you please add some edge cases here, like if the entire series is
NA, or if the series has a MultiIndex?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 595646)
Time Spent: 80h (was: 79h 50m)
> Implement all pandas operations (or raise WontImplementError)
> -------------------------------------------------------------
>
> Key: BEAM-9547
> URL: https://issues.apache.org/jira/browse/BEAM-9547
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Robert Bradshaw
> Priority: P2
> Labels: dataframe-api
> Time Spent: 80h
> Remaining Estimate: 0h
>
> We should have an implementation for every DataFrame, Series, and GroupBy
> method. Everything that's not possible to implement should get a default
> implementation that raises WontImplementError
> See https://github.com/apache/beam/pull/10757#discussion_r389132292
> Progress at the individual operation level is tracked in a
> [spreadsheet|https://docs.google.com/spreadsheets/d/1hHAaJ0n0k2tw465ORs5tfdy4Lg0DnGWIQ53cLjAhel0/edit],
> consider requesting edit access if you'd like to help out.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
