[
https://issues.apache.org/jira/browse/BEAM-10670?focusedWorklogId=595703&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-595703
]
ASF GitHub Bot logged work on BEAM-10670:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/May/21 23:17
Start Date: 12/May/21 23:17
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#14801:
URL: https://github.com/apache/beam/pull/14801#discussion_r631460477
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SplittableParDo.java
##########
@@ -652,7 +652,9 @@ public void tearDown() {
* <p>TODO(BEAM-10670): Remove the primitive Read and make the splittable
DoFn the only option.
*/
public static void
convertReadBasedSplittableDoFnsToPrimitiveReadsIfNecessary(Pipeline pipeline) {
- if (ExperimentalOptions.hasExperiment(pipeline.getOptions(),
"beam_fn_api_use_deprecated_read")
+ if (!ExperimentalOptions.hasExperiment(pipeline.getOptions(),
"use_sdf_read")
+ || ExperimentalOptions.hasExperiment(
Review comment:
@pulasthi is this issue something that affects you or that you have
noticed?
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SplittableParDo.java
##########
@@ -652,7 +652,9 @@ public void tearDown() {
* <p>TODO(BEAM-10670): Remove the primitive Read and make the splittable
DoFn the only option.
*/
public static void
convertReadBasedSplittableDoFnsToPrimitiveReadsIfNecessary(Pipeline pipeline) {
- if (ExperimentalOptions.hasExperiment(pipeline.getOptions(),
"beam_fn_api_use_deprecated_read")
+ if (!ExperimentalOptions.hasExperiment(pipeline.getOptions(),
"use_sdf_read")
Review comment:
@xinyuiscool is this issue something that affects you or that you have
noticed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 595703)
Time Spent: 41h 10m (was: 41h)
> Make non-portable Splittable DoFn the only option when executing Java "Read"
> transforms
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-10670
> URL: https://issues.apache.org/jira/browse/BEAM-10670
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Ismaël Mejía
> Priority: P1
> Labels: Clarified
> Fix For: 2.30.0
>
> Time Spent: 41h 10m
> Remaining Estimate: 0h
>
> All runners seem to be capable of migrating to splittable DoFn for
> non-portable execution except for Dataflow runner v1 which will internalize
> the current primitive read implementation that is shared across runner
> implementations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
