[
https://issues.apache.org/jira/browse/BEAM-11644?focusedWorklogId=596796&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596796
]
ASF GitHub Bot logged work on BEAM-11644:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/May/21 17:33
Start Date: 14/May/21 17:33
Worklog Time Spent: 10m
Work Description: yifanmai commented on pull request #14647:
URL: https://github.com/apache/beam/pull/14647#issuecomment-841396010
The test breakages are addressed in #14594. I'll retest this PR after that
is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 596796)
Time Spent: 7h 20m (was: 7h 10m)
> translations.pack_combiners optimizer causes breaking change to metrics API
> ---------------------------------------------------------------------------
>
> Key: BEAM-11644
> URL: https://issues.apache.org/jira/browse/BEAM-11644
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Affects Versions: 2.27.0
> Reporter: Yifan Mai
> Assignee: Robert Bradshaw
> Priority: P1
> Fix For: 2.28.0
>
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> The translations.pack_combiners optimizer causes a breaking change in the
> public metrics API. The issue arises because metrics are keyed and queryable
> by step name, and the step name can change after combiner packing. Suppose we
> have a pipeline that looks like `pipeline | CombinePerKey(combinefn_1);
> pipeline | CombinePerKey(combinefn_2)` and both combinefn_1 and combinefn_2
> increment the same counter per input element. Previously, the result would
> have two counters, one each for step combinefn_1 and combinefn_2; both will
> have value num_input_elements. After combiner packing, the result will have
> one counter for Packed[combinefn_1, combinefn] with value 2 *
> num_input_elements.
> Unfortunately there is no easy fix for this because the runner has to somehow
> be aware that a step is a packed step and use the appropriate metrics
> container for the sub-step.
> The short term workaround is to (1) add a note for 2.27 under known issues
> and (2) make this phase opt-in in 2.28.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
