[
https://issues.apache.org/jira/browse/BEAM-6718?focusedWorklogId=202861&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-202861
]
ASF GitHub Bot logged work on BEAM-6718:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/19 20:56
Start Date: 22/Feb/19 20:56
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7904:
[BEAM-6718] Fix BigQuery SQL postcommit
URL: https://github.com/apache/beam/pull/7904#discussion_r259507116
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/AvroUtils.java
##########
@@ -17,14 +17,22 @@
*/
package org.apache.beam.sdk.io.gcp.bigquery;
+import com.google.common.collect.ImmutableSet;
import java.util.ArrayList;
import java.util.List;
+import java.util.Set;
import org.apache.beam.sdk.schemas.Schema.Field;
import org.apache.beam.sdk.schemas.Schema.TypeName;
import org.joda.time.Instant;
/** Utils to help convert Apache Avro types to Beam types. */
public class AvroUtils {
+ // TODO: BigQuery shouldn't know about SQL internal logical types.
Review comment:
Can you file a Jira about this. It seems like a pretty big deal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 202861)
Time Spent: 1h 10m (was: 1h)
> Logical types PR seems to break SQL postcommits
> -----------------------------------------------
>
> Key: BEAM-6718
> URL: https://issues.apache.org/jira/browse/BEAM-6718
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Reuven Lax
> Priority: Critical
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Starting here it has been red on BQ integration test:
> https://builds.apache.org/job/beam_PostCommit_SQL/634/
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
