[
https://issues.apache.org/jira/browse/BEAM-12320?focusedWorklogId=597799&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597799
]
ASF GitHub Bot logged work on BEAM-12320:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/21 17:25
Start Date: 17/May/21 17:25
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #14785:
URL: https://github.com/apache/beam/pull/14785#issuecomment-842500399
> TBH I'm not sure why we use TestPubsubSignal instead of a regular PAssert
here -- especially when signaling via pubsub seems like an additional source of
flakiness.
Good point, I'm not sure either. AFAICT the only thing we _need_
`TestPubsubSignal` for is to get a signal when the pipeline starts so we know
when to start injecting input data. Perhaps we should replace all usages of
signalSuccessWhen with a PAssert and get rid of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 597799)
Time Spent: 1h 10m (was: 1h)
> PubsubTableProviderIT.testSQLSelectsArrayAttributes[0] failing in SQL
> PostCommit
> --------------------------------------------------------------------------------
>
> Key: BEAM-12320
> URL: https://issues.apache.org/jira/browse/BEAM-12320
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql, test-failures
> Reporter: Brian Hulette
> Assignee: Kyle Weaver
> Priority: P1
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Failing since https://ci-beam.apache.org/job/beam_PostCommit_SQL/6260/
> {code}
> java.lang.AssertionError: Did not receive signal on
> projects/apache-beam-testing/subscriptions/result-subscription--1731534761628855545
> in 60s
> at
> org.apache.beam.sdk.io.gcp.pubsub.TestPubsubSignal.pollForResultForDuration(TestPubsubSignal.java:341)
> at
> org.apache.beam.sdk.io.gcp.pubsub.TestPubsubSignal.waitForSuccess(TestPubsubSignal.java:288)
> at
> org.apache.beam.sdk.extensions.sql.meta.provider.pubsub.PubsubTableProviderIT.testSQLSelectsArrayAttributes(PubsubTableProviderIT.java:256)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
