[ 
https://issues.apache.org/jira/browse/BEAM-11984?focusedWorklogId=599348&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-599348
 ]

ASF GitHub Bot logged work on BEAM-11984:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/May/21 17:16
            Start Date: 19/May/21 17:16
    Worklog Time Spent: 10m 
      Work Description: ajamato commented on a change in pull request #14770:
URL: https://github.com/apache/beam/pull/14770#discussion_r635437164



##########
File path: sdks/python/apache_beam/io/gcp/gcsio.py
##########
@@ -643,9 +665,23 @@ def _start_upload(self):
     #
     # The uploader by default transfers data in chunks of 1024 * 1024 bytes at
     # a time, buffering writes until that size is reached.
+
+    # Create a request count metric
+    resource = resource_identifiers.GoogleCloudStorage(self._bucket)
+    labels = {
+        monitoring_infos.SERVICE_LABEL: 'Storage',

Review comment:
       Was the project not available on the API response after the first call? 
When you ran it on a pipeline were you able to see it populated on the API 
responses with logging?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 599348)
    Time Spent: 3h 50m  (was: 3h 40m)

> Python GCS - Implement IO Request Count metrics
> -----------------------------------------------
>
>                 Key: BEAM-11984
>                 URL: https://issues.apache.org/jira/browse/BEAM-11984
>             Project: Beam
>          Issue Type: Test
>          Components: io-py-gcp
>            Reporter: Alex Amato
>            Assignee: Rogelio Miguel Hernandez Sandoval
>            Priority: P2
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> Reference PRs (See BigQuery IO example) and detailed explanation of what's 
> needed to instrument this IO with Request Count metrics is found in this 
> handoff doc:
> [https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'|https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'?authuser=0]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to