[
https://issues.apache.org/jira/browse/BEAM-11359?focusedWorklogId=599369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-599369
]
ASF GitHub Bot logged work on BEAM-11359:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/21 17:54
Start Date: 19/May/21 17:54
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #14745:
URL: https://github.com/apache/beam/pull/14745#discussion_r635463865
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_read_internal.py
##########
@@ -207,6 +206,10 @@ def process(self,
table_reference.datasetId,
table_reference.tableId)
+ bq._delete_dataset(
Review comment:
we should only delete the dataset if we were the ones creating it. Can
you add logic to bigquery_tools around `create_temporary_dataset` that lets us
know if we created the dtaset and thus should remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 599369)
Time Spent: 1h 20m (was: 1h 10m)
> Clean up temporary dataset after ReadAllFromBQ executes
> -------------------------------------------------------
>
> Key: BEAM-11359
> URL: https://issues.apache.org/jira/browse/BEAM-11359
> Project: Beam
> Issue Type: Improvement
> Components: io-py-gcp
> Reporter: Pablo Estrada
> Priority: P3
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently, the transform creates (or receives) a temp dataset and it does not
> clean it up. Only one is created per pipeline, so it's not too bad, but it's
> not ideal.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
