[
https://issues.apache.org/jira/browse/BEAM-10670?focusedWorklogId=599448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-599448
]
ASF GitHub Bot logged work on BEAM-10670:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/21 20:53
Start Date: 19/May/21 20:53
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #14801:
URL: https://github.com/apache/beam/pull/14801#discussion_r635576996
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkRunner.java
##########
@@ -74,7 +75,19 @@ protected FlinkRunner(FlinkPipelineOptions options) {
@Override
public PipelineResult run(Pipeline pipeline) {
-
SplittableParDo.convertReadBasedSplittableDoFnsToPrimitiveReadsIfNecessary(pipeline);
+ // Portable flink only support SDF as read.
Review comment:
There is no `deprecated read` under `beam_fn_api` context. Splittable
DoFn is the only source-like operation when with `beam_fn_api`. So if a fnapi
job is using `deprecated read`, there is no runtime error but the pipeline will
just stuck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 599448)
Time Spent: 44h 10m (was: 44h)
> Make non-portable Splittable DoFn the only option when executing Java "Read"
> transforms
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-10670
> URL: https://issues.apache.org/jira/browse/BEAM-10670
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Ismaël Mejía
> Priority: P1
> Labels: Clarified
> Fix For: 2.30.0
>
> Time Spent: 44h 10m
> Remaining Estimate: 0h
>
> All runners seem to be capable of migrating to splittable DoFn for
> non-portable execution except for Dataflow runner v1 which will internalize
> the current primitive read implementation that is shared across runner
> implementations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
