[
https://issues.apache.org/jira/browse/BEAM-12378?focusedWorklogId=600539&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600539
]
ASF GitHub Bot logged work on BEAM-12378:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/21 17:43
Start Date: 21/May/21 17:43
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #14852:
URL: https://github.com/apache/beam/pull/14852#issuecomment-846129530
@anantdamle I'm not completely sure I understand the use case. One comment I
will make on the implementation, is that the existing GroupIntoBatches is very
careful to mostly append to the BagState, and only to read from the BagState
when it's ready to flush it. Your version reads the bag on every element, which
can be very expensive (in fact it is O(n^2) in the number of elements).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 600539)
Time Spent: 50m (was: 40m)
> GroupIntoBatches should support byte-size batches
> -------------------------------------------------
>
> Key: BEAM-12378
> URL: https://issues.apache.org/jira/browse/BEAM-12378
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Reuven Lax
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
