[
https://issues.apache.org/jira/browse/BEAM-10670?focusedWorklogId=600689&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600689
]
ASF GitHub Bot logged work on BEAM-10670:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/21 22:58
Start Date: 21/May/21 22:58
Worklog Time Spent: 10m
Work Description: ihji commented on a change in pull request #14844:
URL: https://github.com/apache/beam/pull/14844#discussion_r637287096
##########
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/Twister2Runner.java
##########
@@ -145,7 +151,16 @@ public PipelineResult runTest(Pipeline pipeline) {
Twister2PipelineExecutionEnvironment env = new
Twister2PipelineExecutionEnvironment(options);
LOG.info("Translating pipeline to Twister2 program.");
pipeline.replaceAll(getDefaultOverrides());
+ // TODO(BEAM-10670): Use SDF read as default when we address performance
issue.
+ if (!ExperimentalOptions.hasExperiment(pipeline.getOptions(),
"use_sdf_read")) {
+ // Populate experiments directly to have Kafka use legacy read.
+ ExperimentalOptions.addExperiment(
+ pipeline.getOptions().as(ExperimentalOptions.class),
"beam_fn_api_use_deprecated_read");
Review comment:
Looks like only Twister2 runner populates `use_deprecated_read`. Any
reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 600689)
Time Spent: 51.5h (was: 51h 20m)
> Make non-portable Splittable DoFn the only option when executing Java "Read"
> transforms
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-10670
> URL: https://issues.apache.org/jira/browse/BEAM-10670
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Ismaël Mejía
> Priority: P1
> Labels: Clarified
> Fix For: 2.30.0
>
> Time Spent: 51.5h
> Remaining Estimate: 0h
>
> All runners seem to be capable of migrating to splittable DoFn for
> non-portable execution except for Dataflow runner v1 which will internalize
> the current primitive read implementation that is shared across runner
> implementations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
