[ 
https://issues.apache.org/jira/browse/BEAM-5627?focusedWorklogId=203708&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-203708
 ]

ASF GitHub Bot logged work on BEAM-5627:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Feb/19 15:08
            Start Date: 25/Feb/19 15:08
    Worklog Time Spent: 10m 
      Work Description: Juta commented on pull request #7878: 
[BEAM-5627][BEAM-6569] run gcsio tests
URL: https://github.com/apache/beam/pull/7878#discussion_r259866902
 
 

 ##########
 File path: sdks/python/tox.ini
 ##########
 @@ -109,7 +109,7 @@ setenv =
   RUN_SKIPPED_PY3_TESTS=0
 extras = test,gcp
 modules =
-  
apache_beam.typehints,apache_beam.coders,apache_beam.options,apache_beam.tools,apache_beam.utils,apache_beam.internal,apache_beam.metrics,apache_beam.portability,apache_beam.pipeline_test,apache_beam.pvalue_test,apache_beam.runners,apache_beam.io.hadoopfilesystem_test,apache_beam.io.gcp.tests.utils_test,apache_beam.io.gcp.big_query_query_to_table_it_test,apache_beam.io.gcp.bigquery_io_read_it_test,apache_beam.io.gcp.bigquery_test,apache_beam.io.gcp.pubsub_integration_test,apache_beam.io.hdfs_integration_test,apache_beam.io.gcp.internal,apache_beam.io.filesystem_test,apache_beam.io.filesystems_test,apache_beam.io.sources_test,apache_beam.transforms,apache_beam.testing,apache_beam.io.filesystemio_test,apache_beam.io.localfilesystem_test,apache_beam.io.range_trackers_test,apache_beam.io.restriction_trackers_test,apache_beam.io.source_test_utils_test,apache_beam.io.concat_source_test,apache_beam.io.filebasedsink_test,apache_beam.io.filebasedsource_test,apache_beam.io.textio_test,apache_beam.io.tfrecordio_test,apache_beam.examples.wordcount_debugging_test,apache_beam.examples.wordcount_minimal_test,apache_beam.examples.wordcount_test,apache_beam.io.parquetio_test,apache_beam.io.gcp.gcsfilesystem_test,apache_beam.io.gcp.gcsio_integration_test,apache_beam.io.gcp.bigquery_test,apache_beam.io.gcp.big_query_query_to_table_it_test,apache_beam.io.gcp.bigquery_io_read_it_test,apache_beam.io.gcp.bigquery_tools_test,apache_beam.io.gcp.pubsub_integration_test,apache_beam.io.gcp.pubsub_test,apache_beam.io.gcp.datastore,apache_beam.io.gcp.datastore_write_it_test
+  
apache_beam.typehints,apache_beam.coders,apache_beam.options,apache_beam.tools,apache_beam.utils,apache_beam.internal,apache_beam.metrics,apache_beam.portability,apache_beam.pipeline_test,apache_beam.pvalue_test,apache_beam.runners,apache_beam.io.hadoopfilesystem_test,apache_beam.io.gcp.tests.utils_test,apache_beam.io.gcp.big_query_query_to_table_it_test,apache_beam.io.gcp.bigquery_io_read_it_test,apache_beam.io.gcp.bigquery_test,apache_beam.io.gcp.pubsub_integration_test,apache_beam.io.hdfs_integration_test,apache_beam.io.gcp.internal,apache_beam.io.filesystem_test,apache_beam.io.filesystems_test,apache_beam.io.sources_test,apache_beam.transforms,apache_beam.testing,apache_beam.io.filesystemio_test,apache_beam.io.localfilesystem_test,apache_beam.io.range_trackers_test,apache_beam.io.restriction_trackers_test,apache_beam.io.source_test_utils_test,apache_beam.io.concat_source_test,apache_beam.io.filebasedsink_test,apache_beam.io.filebasedsource_test,apache_beam.io.textio_test,apache_beam.io.tfrecordio_test,apache_beam.examples.wordcount_debugging_test,apache_beam.examples.wordcount_minimal_test,apache_beam.examples.wordcount_test,apache_beam.io.parquetio_test,apache_beam.io.gcp.gcsfilesystem_test,apache_beam.io.gcp.gcsio_integration_test,apache_beam.io.gcp.bigquery_test,apache_beam.io.gcp.big_query_query_to_table_it_test,apache_beam.io.gcp.bigquery_io_read_it_test,apache_beam.io.gcp.bigquery_tools_test,apache_beam.io.gcp.pubsub_integration_test,apache_beam.io.gcp.pubsub_test,apache_beam.io.gcp.datastore,apache_beam.io.gcp.datastore_write_it_test,apache_beam.io.gcp.gcsio_test
 
 Review comment:
   Yes, I now simplified it
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 203708)
    Time Spent: 4h 10m  (was: 4h)

> Investigate why test_split_at_fraction_exhaustive consistently fails to split 
> after 101 attempts on Python 3
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-5627
>                 URL: https://issues.apache.org/jira/browse/BEAM-5627
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Valentyn Tymofieiev
>            Assignee: Juta Staes
>            Priority: Minor
>              Labels: triaged
>             Fix For: Not applicable
>
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> ERROR: test_split_at_fraction_exhaustive 
> (apache_beam.io.source_test_utils_test.SourceTestUtilsTest)
>  ----------------------------------------------------------------------
>  Traceback (most recent call last):
>    File 
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/source_test_utils_test.py",
>  line 120, in test_split_at_fraction_exhaustive
>      source = self._create_source(data)
>    File 
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/source_test_utils_test.py",
>  line 43, in _create_source
>      source = LineSource(self._create_file_with_data(data))
>    File 
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/source_test_utils_test.py",
>  line 35, in _create_file_with_data
>      f.write(line + '\n')
>    File 
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/target/.tox/py3/lib/python3.5/tempfile.py",
>  line 622, in func_wrapper
>      return func(*args, **kwargs)
> TypeError: a bytes-like object is required, not 'str'
> Also similar:
> ======================================================================
>  ERROR: test_file_sink_writing 
> (apache_beam.io.filebasedsink_test.TestFileBasedSink)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>    File 
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/   
>        apache_beam/io/filebasedsink_test.py", line 121, in 
> test_file_sink_writing
>       init_token, writer_results = self._common_init(sink)
>     File 
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/   
>        apache_beam/io/filebasedsink_test.py", line 103, in _common_init
>       writer1 = sink.open_writer(init_token, '1')
>     File 
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/   
>        apache_beam/options/value_provider.py", line 133, in _f
>       return fnc(self, *args, **kwargs)
>     File 
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/   
>        apache_beam/io/filebasedsink.py", line 185, in open_writer
>     return FileBasedSinkWriter(self, os.path.join(init_result, uid) + suffix)
>     File 
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/   
>        apache_beam/io/filebasedsink.py", line 385, in __init__
>       self.temp_handle = self.sink.open(temp_shard_path)
>     File 
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/   
>        apache_beam/io/filebasedsink_test.py", line 82, in open
>       file_handle.write('[start]')
>   TypeError: a bytes-like object is required, not 'str'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to