[
https://issues.apache.org/jira/browse/BEAM-11838?focusedWorklogId=601238&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601238
]
ASF GitHub Bot logged work on BEAM-11838:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/21 15:39
Start Date: 24/May/21 15:39
Worklog Time Spent: 10m
Work Description: benWize commented on a change in pull request #14829:
URL: https://github.com/apache/beam/pull/14829#discussion_r638061084
##########
File path:
sdks/java/io/debezium/src/main/java/org/apache/beam/io/debezium/Connectors.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.io.debezium;
+
+import io.debezium.connector.db2.Db2Connector;
+import io.debezium.connector.mysql.MySqlConnector;
+import io.debezium.connector.oracle.OracleConnector;
+import io.debezium.connector.postgresql.PostgresConnector;
+import io.debezium.connector.sqlserver.SqlServerConnector;
+import org.apache.kafka.connect.source.SourceConnector;
+
+/** Enumeration of debezium connectors. */
+public enum Connectors {
+ MYSQL("MySQL", MySqlConnector.class),
+ POSTGRES("PostgreSQL", PostgresConnector.class),
+ SQLSERVER("SQLServer", SqlServerConnector.class),
+ ORACLE("Oracle", OracleConnector.class),
+ DB2("DB2", Db2Connector.class),
Review comment:
Done
##########
File path:
sdks/java/io/debezium/src/main/java/org/apache/beam/io/debezium/KafkaSourceConsumerFn.java
##########
@@ -94,7 +95,7 @@ public KafkaSourceConsumerFn(
Class<?> connectorClass, SourceRecordMapper<T> fn, long minutesToRun) {
Review comment:
Yes, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 601238)
Time Spent: 7h 40m (was: 7.5h)
> An x-lang wrapper for DebeziumIO
> --------------------------------
>
> Key: BEAM-11838
> URL: https://issues.apache.org/jira/browse/BEAM-11838
> Project: Beam
> Issue Type: Bug
> Components: cross-language, io-java-debezium
> Reporter: Pablo Estrada
> Assignee: Benjamin Gonzalez
> Priority: P2
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> DebeziumIO outputs data in JSON format by default, so it's a perfect
> candidate to be made available as a xlang transform.
> The DebeziumIO module provides a base to implement this, but for an
> effective, easy-to-use connector in Python, we will need the following things:
> * A new Java module that includes the per-database dependencies (Debezium's
> MySQL, Postgres, DB2, Oracle connector dependencies). This is necessary so
> that users can simply specify a database on the Python side, and the Java
> side will automatically provide the dependency.
> * A thorough review of the current default JSON output from DebeziumIO
> * A set of parameters to be received by the Python wrapper. Maybe we'll use
> the same format as the existing DebeziumIO (i.e. mandatory parameters: host,
> user, password; and keyword parameters)
>
> A short guide:
> [https://beam.apache.org/documentation/programming-guide/#mulit-language-pipelines]
> An example of this kind of change: [https://github.com/apache/beam/pull/12145]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
