[ 
https://issues.apache.org/jira/browse/BEAM-12276?focusedWorklogId=601296&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601296
 ]

ASF GitHub Bot logged work on BEAM-12276:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/May/21 17:15
            Start Date: 24/May/21 17:15
    Worklog Time Spent: 10m 
      Work Description: kennknowles commented on pull request #14718:
URL: https://github.com/apache/beam/pull/14718#issuecomment-847204036


   it is a good point about `timer.set(window.maxTimestamp().plus(X))`. I 
believe we should then require to have a separate output timestamp like 
`timer.set(window.maxTimestamp().plus(X)).withOutputTimestamp(window.maxTimestamp())`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 601296)
    Time Spent: 5h  (was: 4h 50m)

> Timer.withOutputTimestamp(Instant).offset(Duration).setRelative() might fail 
> unexpectedly
> -----------------------------------------------------------------------------------------
>
>                 Key: BEAM-12276
>                 URL: https://issues.apache.org/jira/browse/BEAM-12276
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 2.30.0
>            Reporter: Jan Lukavský
>            Assignee: Jan Lukavský
>            Priority: P2
>             Fix For: 2.31.0
>
>          Time Spent: 5h
>  Remaining Estimate: 0h
>
> We check that timer's output timestamp is not before timer fire timestamp. 
> The fire timestamp is unknown to user when setting a relative timer and 
> therefore cannot be checked in user code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to