[
https://issues.apache.org/jira/browse/BEAM-6725?focusedWorklogId=203854&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-203854
]
ASF GitHub Bot logged work on BEAM-6725:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/19 19:17
Start Date: 25/Feb/19 19:17
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #7941: [BEAM-6725]
share some Flink job invocation code with Samza runner
URL: https://github.com/apache/beam/pull/7941
- This PR assumes the extra layer of abstraction allowing runners to define
their own execution wrappers was heretofore inflating maintenance cost, so I
changed JobInvoker and JobInvocation from interfaces to abstract classes to
handle execution logic up until the pipeline is actually run. This means other
portable runners will now share the Flink runner's future-based execution
framework.
- Unlike #6714, this change required modifications to the Samza runner.
- Some of the helper methods remaining in FlinkJobInvocation may also be
reusable; if I find them useful to the Spark runner, I will move them to
JobInvocation in a future PR.
R: @robertwb, @mxm, @angoenka, @lhaiesp
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 203854)
Time Spent: 10m
Remaining Estimate: 0h
> Move runner-agnostic code out of FlinkJobInvocation
> ---------------------------------------------------
>
> Key: BEAM-6725
> URL: https://issues.apache.org/jira/browse/BEAM-6725
> Project: Beam
> Issue Type: Task
> Components: runner-flink, runner-samza, runner-spark
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Labels: portability
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Like BEAM-6714, FlinkJobInvocation contains some code (for asynchronously
> running jobs) that isn't really Flink specific and therefore could/should be
> reused by other portable runners. I'm thinking instead of an interface,
> JobInvocation should be made an abstract class that implements the methods
> that it currently abstracts, with an abstract method `runPipeline` for the
> runner-specific details.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
