[
https://issues.apache.org/jira/browse/BEAM-12385?focusedWorklogId=602364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-602364
]
ASF GitHub Bot logged work on BEAM-12385:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/21 14:23
Start Date: 26/May/21 14:23
Worklog Time Spent: 10m
Work Description: anantdamle commented on a change in pull request #14858:
URL: https://github.com/apache/beam/pull/14858#discussion_r639777493
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java
##########
@@ -906,6 +906,18 @@ private void readObject(ObjectInputStream in) throws
IOException, ClassNotFoundE
.map(x -> getFieldSchema(x.getType(), x.getName(),
namespace))
.collect(Collectors.toList()));
break;
+
+ case "NVARCHAR":
Review comment:
The proposed change is as part of a switch-case statement, and needs a
String constant, so can't use the `[Enum].getName()` method. Sorry, am unable
to think of any other way to limit this to AvroUtils only,
the alternative I can think of is making changes upstream in the
`SchemaUtil#jdbcTypeToBeamFieldConverter` method, but I fear it may have a much
wider impact radius.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 602364)
Time Spent: 1h 20m (was: 1h 10m)
> AvroUtils exception when converting JDBC Row to GenericRecord
> -------------------------------------------------------------
>
> Key: BEAM-12385
> URL: https://issues.apache.org/jira/browse/BEAM-12385
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Anant Damle
> Assignee: Anant Damle
> Priority: P2
> Fix For: 2.31.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> `{{AvroUtils.toAvroSchema()}}` and `{{AvroUtils.toGenericRecord()}}` throw
> exception for JDBC specific logical types like: `{{DATE}}`, `{{NVARCHAR}}`,
> `{{VARCHAR}}`, `{{LONGVARCHAR}}` etc.
>
> {code:java}
> pipeline
> .apply(JdbcIO.readRows()...)
> .apply(MapElements.via(
> (Row row) -> {
> // This statement throws Exception "Unhandled Logical Type"
> org.apache.avro.Schema schema =
> AvroUtils.toAvroSchema(row.getSchema());
> }));
> {code}
>
>
> This can be handled by adding additional case-statements in AvroUtils:
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
