[
https://issues.apache.org/jira/browse/BEAM-3713?focusedWorklogId=604867&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-604867
]
ASF GitHub Bot logged work on BEAM-3713:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/21 01:19
Start Date: 02/Jun/21 01:19
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #14795:
URL: https://github.com/apache/beam/pull/14795#discussion_r643585370
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -2101,13 +2101,13 @@ class BeamModulePlugin implements Plugin<Project> {
config.cleanupJobServer.mustRunAfter javaTask
// Task for running testcases in Python SDK
- def testOpts = [
- "--attr=${config.pythonTestAttr}"
- ]
def beamPythonTestPipelineOptions = [
"pipeline_opts": config.pythonPipelineOptions + sdkLocationOpt,
- "test_opts": testOpts + config.nosetestsOptions,
- "suite": "xlangValidateRunner"
+ "test_opts": config.pytestOptions,
+ "suite": "xlangValidateRunner",
+ "pytest": true, // TODO(BEAM-3713): Remove this once nose is removed.
+ // TODO(BEAM-10507): Remove no_xlang_transforms after fixing
Review comment:
I think you can remove this TODO. We will always want to exclude tests
marked with `no_xlang_transforms`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 604867)
Time Spent: 64h 20m (was: 64h 10m)
> Consider moving away from nose to nose2 or pytest.
> --------------------------------------------------
>
> Key: BEAM-3713
> URL: https://issues.apache.org/jira/browse/BEAM-3713
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core, testing
> Reporter: Robert Bradshaw
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 64h 20m
> Remaining Estimate: 0h
>
> Per
> [https://nose.readthedocs.io/en/latest/|https://nose.readthedocs.io/en/latest/,]
> , nose is in maintenance mode.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
