[
https://issues.apache.org/jira/browse/BEAM-12419?focusedWorklogId=605404&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-605404
]
ASF GitHub Bot logged work on BEAM-12419:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/21 17:52
Start Date: 02/Jun/21 17:52
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #14923:
URL: https://github.com/apache/beam/pull/14923#discussion_r644194340
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/ExternalEnvironmentFactory.java
##########
@@ -113,6 +113,7 @@ public RemoteEnvironment createEnvironment(Environment
environment, String worke
ManagedChannelFactory.createDefault().forDescriptor(externalPayload.getEndpoint());
BeamFnApi.StartWorkerResponse startWorkerResponse =
BeamFnExternalWorkerPoolGrpc.newBlockingStub(managedChannel)
+ .withWaitForReady()
Review comment:
If I understand correctly, adding `withWaitForReady` will make requests
that formerly failed fast instead block forever. Therefore, I don't think we
should add `withWaitForReady` without also adding a timeout, since otherwise
the user gets no feedback about why their pipeline is stalled. And I think the
timeout should be off by default, since most deployments don't have a problem
with starting the external service ahead of time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 605404)
Time Spent: 1h 50m (was: 1h 40m)
> Timeout/WaitForReady support in java gRPC calls
> -----------------------------------------------
>
> Key: BEAM-12419
> URL: https://issues.apache.org/jira/browse/BEAM-12419
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Ke Wu
> Assignee: Ke Wu
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> gRPC calls in java Portable pipeline does not have retry or timeout enabled,
> unlike python BEAM-7933
> Email discussion:
> https://lists.apache.org/thread.html/rd4de8d54b22777913a8e20ee04e8b9d5c9aa7c16942ab36d7d168425%40%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
