[
https://issues.apache.org/jira/browse/BEAM-11811?focusedWorklogId=607352&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607352
]
ASF GitHub Bot logged work on BEAM-11811:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/21 22:06
Start Date: 04/Jun/21 22:06
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #14938:
URL: https://github.com/apache/beam/pull/14938#issuecomment-855030476
> Ok, didn't see that.
>
> Would it perhaps be better to make it part of WorkerOptions.validate
rather than add it directly to PipelineOptionsValidator?
WorkerOptions.validate calls methods in PipelineOptionsValidator, so I'm not
sure what you mean.
https://github.com/apache/beam/blob/92386d781b5d502c4ea47a0894b72ca57854553d/sdks/python/apache_beam/options/pipeline_options.py#L934
Putting most of the actual logic into PipelineOptionsValidator is preferable
though (similar to existing code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 607352)
Time Spent: 3h 20m (was: 3h 10m)
> Don't allow numWorkers > maxNumWorkers.
> ---------------------------------------
>
> Key: BEAM-11811
> URL: https://issues.apache.org/jira/browse/BEAM-11811
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Kyle Weaver
> Assignee: Zachary Houfek
> Priority: P3
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Right now Dataflow jobs misconfigured with numWorkers > maxNumWorkers will be
> allowed to submit, but will get stuck in the PENDING state, and cannot be
> cancelled normally by users. We should implement a sanity check in each SDK
> to prevent misconfigured jobs from submitting.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
