[
https://issues.apache.org/jira/browse/BEAM-12074?focusedWorklogId=608690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-608690
]
ASF GitHub Bot logged work on BEAM-12074:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/21 19:32
Start Date: 08/Jun/21 19:32
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#14876:
URL: https://github.com/apache/beam/pull/14876#discussion_r647736573
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -2115,11 +2115,18 @@ def fill_matrix(*args):
requires_partition_by=partitionings.Singleton(),
proxy=proxy))
+ @frame_base.with_docs_from(pd.DataFrame)
@frame_base.args_to_kwargs(pd.DataFrame)
@frame_base.populate_defaults(pd.DataFrame)
def corrwith(self, other, axis, drop, method):
- if axis not in (0, 'index'):
- raise NotImplementedError('corrwith(axis=%r)' % axis)
+ if axis in (1, 'columns'):
Review comment:
Usually what happens for bad arguments like this is that an error gets
raised when we generate the proxy object, which is nice because it's an actual
pandas error.
I went to verify that in this particular case, and we weren't actually
raising an error because the `axis` argument wasn't passed through for proxy
generation. I fixed this (and added a test) in 2a31d7c. So thank you for asking!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 608690)
Time Spent: 20h 50m (was: 20h 40m)
> Add API Documentation for the DataFrame API
> -------------------------------------------
>
> Key: BEAM-12074
> URL: https://issues.apache.org/jira/browse/BEAM-12074
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Labels: dataframe-api, stale-P2
> Time Spent: 20h 50m
> Remaining Estimate: 0h
>
> For the most part this can be pulled directly from pandas methods, but we
> should add specific notes about any divergences that the Beam DataFrame API
> has from pandas.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
