[
https://issues.apache.org/jira/browse/BEAM-9640?focusedWorklogId=608772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-608772
]
ASF GitHub Bot logged work on BEAM-9640:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/21 21:33
Start Date: 08/Jun/21 21:33
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #11296:
URL: https://github.com/apache/beam/pull/11296#discussion_r647808822
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -364,10 +368,36 @@ def run_stages(self,
bundle_context_manager = execution.BundleContextManager(
runner_execution_context, stage, self._num_workers)
+ assert (
+ runner_execution_context.watermark_manager.get_stage_node(
+ bundle_context_manager.stage.name
+ ).input_watermark() == timestamp.MAX_TIMESTAMP), (
+ 'wrong watermark for %s. Expected %s, but got %s.' % (
+ runner_execution_context.watermark_manager.get_stage_node(
+ bundle_context_manager.stage.name),
+ timestamp.MAX_TIMESTAMP,
+ runner_execution_context.watermark_manager.get_stage_node(
+ bundle_context_manager.stage.name
+ ).input_watermark()
+ )
+ )
+
stage_results = self._run_stage(
- runner_execution_context,
- bundle_context_manager,
+ runner_execution_context, bundle_context_manager)
+
+ assert (
+ runner_execution_context.watermark_manager.get_stage_node(
+ bundle_context_manager.stage.name
+ ).input_watermark() == timestamp.MAX_TIMESTAMP), (
Review comment:
ah thanks for the catch. fixed that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 608772)
Time Spent: 11h 50m (was: 11h 40m)
> Track PCollection watermark across bundle executions
> ----------------------------------------------------
>
> Key: BEAM-9640
> URL: https://issues.apache.org/jira/browse/BEAM-9640
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Priority: P3
> Attachments: graph.png
>
> Time Spent: 11h 50m
> Remaining Estimate: 0h
>
> This can be done without relying on the watermark manager for execution.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
