[
https://issues.apache.org/jira/browse/BEAM-12379?focusedWorklogId=608805&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-608805
]
ASF GitHub Bot logged work on BEAM-12379:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/21 22:31
Start Date: 08/Jun/21 22:31
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #14853:
URL: https://github.com/apache/beam/pull/14853#discussion_r647838886
##########
File path: sdks/python/apache_beam/dataframe/frames_test.py
##########
@@ -122,7 +123,12 @@ def _run_test(self, func, *args, distributed=True,
nonparallel=False):
generated twice, once outside of an allow_non_parallel_operations
block (to verify NonParallelOperation is raised), and again inside
of an allow_non_parallel_operations block to actually generate an
- expression to verify."""
+ expression to verify.
+ check_proxy (bool): Whether or not to check that the proxy of the
+ generated expression matches the actual result, defaults to True.
Review comment:
For my education, what are the implications of us currently having
mismatch proxies? (I am not very familiar with how proxy are actually used, and
when they are generated)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 608805)
Time Spent: 3h 20m (was: 3h 10m)
> Some DataFrame operations yield incorrect proxies
> -------------------------------------------------
>
> Key: BEAM-12379
> URL: https://issues.apache.org/jira/browse/BEAM-12379
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Labels: dataframe-api
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> There are some operations that yield proxies which do not match the data they
> produce at runtime. We should add tests that verify proxies match, and fix
> the operations where they dont.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
