[
https://issues.apache.org/jira/browse/BEAM-6670?focusedWorklogId=205145&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-205145
]
ASF GitHub Bot logged work on BEAM-6670:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Feb/19 13:25
Start Date: 27/Feb/19 13:25
Worklog Time Spent: 10m
Work Description: Noctune commented on pull request #7956: [BEAM-6670]
Add option to disable reshuffling of JdbcIO
URL: https://github.com/apache/beam/pull/7956
Adds a `withReshuffle` method on JdbcIO classes so reshuffling can be
disabled.
This can be useful when an operator immediately after `JdbcIO.Read`
reshuffles anyway. In my case I am first reading 20 or so tables and then
joining them using a `CoGroupByKey`. Since the CoGroupByKey operation would
distribute the data anyway, the work to reshuffle the 20 tables is wasted and
results in a much more complex graph than necessary.
There are no tests for this, as reshuffling is not easily testable as it
should practically have "no effect". However, there are no tests for the
original reparallelization logic either.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 205145)
Time Spent: 10m
Remaining Estimate: 0h
> Option to disable reparallelization in JdbcIO.Read
> --------------------------------------------------
>
> Key: BEAM-6670
> URL: https://issues.apache.org/jira/browse/BEAM-6670
> Project: Beam
> Issue Type: Wish
> Components: io-java-jdbc
> Reporter: Mike Pedersen
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I'm doing approx. 20 JDBC queries against a database and then joining them
> together in a group by. Every single one of these queries does a reshuffle,
> which is sort of useless due to them being fed to a CoGroupByKey immediately
> afterwards.
> Reshuffle by default seems sensible by the principle of least surprise, but
> it would be nice to have a way to disable it when it's not necessary. For
> example a "withReshuffle(boolean)" method.
> This should be an easy addition and I am willing to add this if it sounds
> reasonable enough.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
