[
https://issues.apache.org/jira/browse/BEAM-8137?focusedWorklogId=609365&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-609365
]
ASF GitHub Bot logged work on BEAM-8137:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/21 20:17
Start Date: 09/Jun/21 20:17
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #14942:
URL: https://github.com/apache/beam/pull/14942#discussion_r648654642
##########
File path:
runners/portability/java/src/main/java/org/apache/beam/runners/portability/ExternalWorkerService.java
##########
@@ -130,15 +131,13 @@ public void close() {}
* up-front and matches the running job. See {@link PipelineOptions}
for further details.
* </ul>
*/
- public static void main(String[] args) throws Exception {
- main(System::getenv);
- }
-
- public static void main(Function<String, String> environmentVarGetter)
throws Exception {
+ public static void main(String[] args) {
LOG.info("Starting external worker service");
- LOG.info("Pipeline options {}",
environmentVarGetter.apply(PIPELINE_OPTIONS_ENV_VAR));
- PipelineOptions options =
-
PipelineOptionsTranslation.fromJson(environmentVarGetter.apply(PIPELINE_OPTIONS_ENV_VAR));
+ final String optionsEnv =
+ checkArgumentNotNull(
+ System.getenv(PIPELINE_OPTIONS_ENV_VAR), "No pipeline options
provided.");
Review comment:
Make the error message actionable. Tell the user how to set
PIPELINE_OPTIONS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 609365)
Time Spent: 6h (was: 5h 50m)
> Worker pool option for Java SDK container
> -----------------------------------------
>
> Key: BEAM-8137
> URL: https://issues.apache.org/jira/browse/BEAM-8137
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Thomas Weise
> Priority: P3
> Labels: Clarified
> Time Spent: 6h
> Remaining Estimate: 0h
>
> The worker pool option was added to the Python SDK container in BEAM-7980.
> Support in the Java SDK container is simpler since it can rely on threading
> and it should be added for feature parity.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
