[
https://issues.apache.org/jira/browse/BEAM-4767?focusedWorklogId=609969&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-609969
]
ASF GitHub Bot logged work on BEAM-4767:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/21 22:24
Start Date: 10/Jun/21 22:24
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#14990:
URL: https://github.com/apache/beam/pull/14990#discussion_r649570125
##########
File path: release/src/main/scripts/set_version.sh
##########
@@ -76,9 +76,6 @@ if [[ -z "$IS_SNAPSHOT_VERSION" ]] ; then
sed -i -e "s/^__version__ = .*/__version__ = '${TARGET_VERSION}'/"
sdks/python/apache_beam/version.py
sed -i -e "s/sdk_version=.*/sdk_version=$TARGET_VERSION/" gradle.properties
sed -i -e "s/SdkVersion = .*/SdkVersion = \"$TARGET_VERSION\"/"
sdks/go/pkg/beam/core/core.go
- # TODO: [BEAM-4767]
- sed -i -e "s/'dataflow.fnapi_container_version' :
.*/'dataflow.fnapi_container_version' : '${TARGET_VERSION}'/"
runners/google-cloud-dataflow-java/build.gradle
- sed -i -e "s/'dataflow.legacy_container_version' :
.*/'dataflow.legacy_container_version' : 'beam-${TARGET_VERSION}'/"
runners/google-cloud-dataflow-java/build.gradle
Review comment:
In this code branch, the version is being set for building an RC tag,
right? This line still used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 609969)
Time Spent: 1h 10m (was: 1h)
> Java should update dataflow.container_version automatically for each release
> ----------------------------------------------------------------------------
>
> Key: BEAM-4767
> URL: https://issues.apache.org/jira/browse/BEAM-4767
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Priority: P3
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
