[
https://issues.apache.org/jira/browse/BEAM-6751?focusedWorklogId=205366&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-205366
]
ASF GitHub Bot logged work on BEAM-6751:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Feb/19 20:21
Start Date: 27/Feb/19 20:21
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #7955: [BEAM-6751]
Extend Kafka EOS mode whitelist / Warn instead of throw
URL: https://github.com/apache/beam/pull/7955#issuecomment-468015438
Whoa, this is kind of an exciting line of code. I had no idea we were doing
stuff like this. I agree with your meta-point. We shouldn't have library
transforms introspecting the runner _at all_.
But I don't think I agree about Flink's support. This message seems coded,
but I assume it means that the transform (like a huge number of IOs) depends on
GroupByKey/Reshuffle providing stable input to the downstream transform. This
should be replaced by `@RequiresStableInput`, which as I understand it might
require waiting for a Flink checkpoint finalization callback or some such, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 205366)
Time Spent: 20m (was: 10m)
> KafkaIO blocks FlinkRunner in EOS mode
> --------------------------------------
>
> Key: BEAM-6751
> URL: https://issues.apache.org/jira/browse/BEAM-6751
> Project: Beam
> Issue Type: Bug
> Components: io-java-kafka, runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Critical
> Fix For: 2.12.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> KafkaIO has a validation check which whitelists certain runners capable of
> provide exactly-once semantics:
> {noformat}
> if ("org.apache.beam.runners.direct.DirectRunner".equals(runner)
> || runner.startsWith("org.apache.beam.runners.dataflow.")
> || runner.startsWith("org.apache.beam.runners.spark.") {
> ...
> {noformat}
> The FlinkRunner supports exactly-once checkpointing but is blocked from using
> Kafka's exactly once mode.
> I wonder if such a list is easily maintainable? I think we should replace the
> list with a warning instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
