[
https://issues.apache.org/jira/browse/BEAM-11086?focusedWorklogId=610032&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-610032
]
ASF GitHub Bot logged work on BEAM-11086:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/21 07:11
Start Date: 14/Jun/21 07:11
Worklog Time Spent: 10m
Work Description: youngoli commented on a change in pull request #14966:
URL: https://github.com/apache/beam/pull/14966#discussion_r649591864
##########
File path: sdks/go/pkg/beam/core/runtime/exec/hash.go
##########
@@ -101,13 +109,18 @@ func (h *stringHasher) Hash(element interface{}) (uint64,
error) {
n := l - i
copy(b[:], s[i:])
h.hash.Write(b[:n])
+ h.we.EncodeSingle(w, h.hash)
return h.hash.Sum64(), nil
}
type numberHasher struct {
+ hash hash.Hash64
+ we WindowEncoder
+ cache []byte
Review comment:
Nit: Cache seems to need a fixed size of 8 bytes for the Hash method to
work correctly, so I'd just initialize it in a newNumberHasher() function or
something similar, instead of leaving it to calling code.
##########
File path: sdks/go/test/integration/driver/driver.go
##########
@@ -69,6 +69,13 @@ func main() {
// {"flatten:dup", primitives.FlattenDup()},
{"reshuffle:reshuffle", primitives.Reshuffle()},
{"reshuffle:reshufflekv", primitives.ReshuffleKV()},
+ {"window:sums", func() *beam.Pipeline {
Review comment:
Is this driver still getting used somewhere? I think we disabled the
gradle commands that were running this on Jenkins, and if so it might be time
to delete this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 610032)
Time Spent: 1h 40m (was: 1.5h)
> [Go SDK] Validate windows are aggregated correctly in GBKs and Combines
> -----------------------------------------------------------------------
>
> Key: BEAM-11086
> URL: https://issues.apache.org/jira/browse/BEAM-11086
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Priority: P3
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Add an integration test to validate windowing behavior against real runners,
> in particular WRT GroupByKey operations.
> This entails writing small batch test pipelines that assign event times, and
> window into those transforms. Windows are assigned by the the runner as per
> the given windowing strategy.
> Code should be added in the sdks/go/test directory
> [https://github.com/apache/beam/tree/master/sdks/go/test/integration/primitives]
> and hooked up so that they're run as part of the post commit tests.
> In particular, a multi-window case with a sliding window, and a lifted
> combiner (like stats.Sum) should be written. It's unlikely the current
> Combiner Lifting implementation takes windows into account correctly, leading
> to correctness issues when they are used simultaneously.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
