[
https://issues.apache.org/jira/browse/BEAM-1251?focusedWorklogId=205441&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-205441
]
ASF GitHub Bot logged work on BEAM-1251:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Feb/19 22:51
Start Date: 27/Feb/19 22:51
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #7953: [BEAM-1251]
Fix Python 3 compatibility bug in pickler.py
URL: https://github.com/apache/beam/pull/7953#discussion_r260980035
##########
File path: sdks/python/apache_beam/internal/pickler.py
##########
@@ -164,7 +164,7 @@ def new_save_module_dict(pickler, obj):
obj_id = id(obj)
if not known_module_dicts or '__file__' in obj or '__package__' in obj:
if obj_id not in known_module_dicts:
- for m in sys.modules.values():
+ for m in list(sys.modules.values()):
Review comment:
Is `list()` essential in line 168? If so please add a comment so that
somebody doesn't try to clean it up, otherwise we can remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 205441)
Time Spent: 28h 10m (was: 28h)
> Python 3 Support
> ----------------
>
> Key: BEAM-1251
> URL: https://issues.apache.org/jira/browse/BEAM-1251
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Eyad Sibai
> Assignee: Robbe
> Priority: Major
> Labels: triaged
> Time Spent: 28h 10m
> Remaining Estimate: 0h
>
> I have been trying to use google datalab with python3. As I see there are
> several packages that does not support python3 yet which google datalab
> depends on. This is one of them.
> https://github.com/GoogleCloudPlatform/DataflowPythonSDK/issues/6
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
