[
https://issues.apache.org/jira/browse/BEAM-6596?focusedWorklogId=205553&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-205553
]
ASF GitHub Bot logged work on BEAM-6596:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/19 01:25
Start Date: 28/Feb/19 01:25
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #7914: [BEAM-6596]
Use multiple interpreter versions for SDK release validation.
URL: https://github.com/apache/beam/pull/7914#discussion_r261015358
##########
File path: release/src/main/scripts/run_rc_validation.sh
##########
@@ -289,283 +290,297 @@ if [[ $confirmation = "y" ]]; then
echo "--------------------------Verifying
Hashes------------------------------------"
sha512sum -c apache-beam-${RELEASE}.zip.sha512
- echo "---------------------------Setting up
virtualenv------------------------------"
sudo `which pip` install --upgrade pip
sudo `which pip` install --upgrade setuptools
sudo `which pip` install --upgrade virtualenv
- virtualenv beam_env
- . beam_env/bin/activate
- echo "--------------------------Installing Python
SDK-------------------------------"
- pip install apache-beam-${RELEASE}.zip
- pip install apache-beam-${RELEASE}.zip[gcp]
+ echo "[Input Required] Please enter Python interpreter(s) separated by space
to use for running validation steps."
+ echo "Sample input: python2.7"
+ echo "Enter empty line to repeat validation steps using all of
${DEFAULT_PYTHON_VERSIONS_TO_VALIDATE[@]}."
- echo "----------------------------Setting up GCP
Sources----------------------------"
- echo "[GCP Project Required] Please input your GCP project:"
- read USER_GCP_PROJECT
- gcloud auth login
- gcloud config set project ${USER_GCP_PROJECT}
-
- MOBILE_GAME_GCS_BUCKET=gs://${USER}_python_validations_bucket
- MOBILE_GAME_DATASET=${USER}_python_validations
- MOBILE_GAME_PUBSUB_TOPIC=leader_board-${USER}-python-topic-1
- gsutil mb -p ${USER_GCP_PROJECT} ${MOBILE_GAME_GCS_BUCKET}
- gcloud alpha pubsub topics delete
projects/${USER_GCP_PROJECT}/topics/${MOBILE_GAME_PUBSUB_TOPIC}
- gcloud alpha pubsub topics create --project=${USER_GCP_PROJECT}
${MOBILE_GAME_PUBSUB_TOPIC}
-
- echo "-----------------------Setting Up Service
Account-----------------------------"
- echo "Please go to GCP IAM console under your project(${USER_GCP_PROJECT})."
- echo "Create a service account as project owner, if you don't have one."
- echo "[Input Required] Please enter your service account email:"
- read USER_SERVICE_ACCOUNT_EMAIL
- SERVICE_ACCOUNT_KEY_JSON=${USER}_json_key.json
- gcloud iam service-accounts keys create ${SERVICE_ACCOUNT_KEY_JSON}
--iam-account ${USER_SERVICE_ACCOUNT_EMAIL}
- export GOOGLE_APPLICATION_CREDENTIALS=$(pwd)/${SERVICE_ACCOUNT_KEY_JSON}
-
- echo "-----------------------Setting up Shell Env
Vars------------------------------"
- # [BEAM-4518]
- FIXED_WINDOW_DURATION=20
- cp ~/.bashrc ~/.bashrc_backup
- echo "export USER_GCP_PROJECT=${USER_GCP_PROJECT}" >> ~/.bashrc
- echo "export MOBILE_GAME_DATASET=${MOBILE_GAME_DATASET}" >> ~/.bashrc
- echo "export MOBILE_GAME_PUBSUB_TOPIC=${MOBILE_GAME_PUBSUB_TOPIC}" >>
~/.bashrc
- echo "export MOBILE_GAME_GCS_BUCKET=${MOBILE_GAME_GCS_BUCKET}" >> ~/.bashrc
- echo "export
GOOGLE_APPLICATION_CREDENTIALS=${GOOGLE_APPLICATION_CREDENTIALS}" >> ~/.bashrc
- echo "export RELEASE=${RELEASE}" >> ~/.bashrc
- echo "export FIXED_WINDOW_DURATION=${FIXED_WINDOW_DURATION}" >> ~/.bashrc
-
-
- echo "--------------------------Updating
~/.m2/settings.xml-------------------------"
- cd ~
- if [[ -d .m2 ]]; then
- mkdir .m2
- fi
- cd .m2
- if [[ -f ~/.m2/settings.xml ]]; then
- mv settings.xml settings_backup.xml
- fi
- touch settings.xml
- echo "<settings>" >> settings.xml
- echo " <profiles>" >> settings.xml
- echo " <profile>" >> settings.xml
- echo " <id>release-repo</id>" >> settings.xml
- echo " <activation>" >> settings.xml
- echo " <activeByDefault>true</activeByDefault>" >> settings.xml
- echo " </activation>" >> settings.xml
- echo " <repositories>" >> settings.xml
- echo " <repository>" >> settings.xml
- echo " <id>Release ${RELEASE} RC${RC_NUM}</id>" >> settings.xml
- echo " <name>Release ${RELEASE} RC${RC_NUM}</name>" >> settings.xml
- echo " <url>${REPO_URL}</url>" >> settings.xml
- echo " </repository>" >> settings.xml
- echo " </repositories>" >> settings.xml
- echo " </profile>" >> settings.xml
- echo " </profiles>" >> settings.xml
- echo "</settings>" >> settings.xml
-
- echo "----------------------Starting Pubsub Java
Injector--------------------------"
- cd ~/${LOCAL_CLONE_DIR}
- mvn archetype:generate \
- -DarchetypeGroupId=org.apache.beam \
- -DarchetypeArtifactId=beam-sdks-java-maven-archetypes-examples \
- -DarchetypeVersion=${RELEASE} \
- -DgroupId=org.example \
- -DartifactId=word-count-beam \
- -Dversion="0.1" \
- -Dpackage=org.apache.beam.examples \
- -DinteractiveMode=false \
- -DarchetypeCatalog=internal
-
- cd word-count-beam
- echo "A new terminal will pop up and start a java top injector."
- gnome-terminal -x sh -c \
- "echo '******************************************************';
- echo '* Running Pubsub Java Injector';
- echo '******************************************************';
- mvn compile exec:java
-Dexec.mainClass=org.apache.beam.examples.complete.game.injector.Injector \
- -Dexec.args='${USER_GCP_PROJECT} ${MOBILE_GAME_PUBSUB_TOPIC} none';
- exec bash"
-
- echo "[Confirmation Required] Please enter y to confirm injector running:"
- read confirmation
- if [[ $confirmation != "y" ]]; then
- echo "Following tests only can be ran when java injector running."
- clean_up
- exit
+ read -a PYTHON_VERSIONS_TO_VALIDATE
+ if [[ -z "$PYTHON_VERSIONS_TO_VALIDATE" ]]; then
+ PYTHON_VERSIONS_TO_VALIDATE=${DEFAULT_PYTHON_VERSIONS_TO_VALIDATE[@]}
fi
- cd ~/${LOCAL_CLONE_DIR}/
+ for py_version in "${PYTHON_VERSIONS_TO_VALIDATE[@]}"
+ do
+ rm -rf ./beam_env
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 205553)
Time Spent: 3h (was: 2h 50m)
> Beam Python SDK release qualification should verify supported Python 3
> versions.
> --------------------------------------------------------------------------------
>
> Key: BEAM-6596
> URL: https://issues.apache.org/jira/browse/BEAM-6596
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Valentyn Tymofieiev
> Priority: Major
> Fix For: 2.11.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> We likely won't get to this for 2.11, but I can't assign a 2.12 as a fix
> version, setting 2.11 for now, and we can move this to 2.12 once this tag is
> available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
