[
https://issues.apache.org/jira/browse/BEAM-6733?focusedWorklogId=205685&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-205685
]
ASF GitHub Bot logged work on BEAM-6733:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/19 09:28
Start Date: 28/Feb/19 09:28
Worklog Time Spent: 10m
Work Description: mxm commented on issue #7940: [BEAM-6733] Use Flink
1.6/1.7 prepareSnapshotPreBarrier to replace BufferedOutputManager
URL: https://github.com/apache/beam/pull/7940#issuecomment-468200929
There is only one copy. I didn't want to copy DoFnOperator but it proved
hard to simplify it without a copy. The good thing is that we have tests in
place for 1.5/1.6/1.7 which ensure that nothing breaks across these versions.
In my opinion this change gives us more insensitive to drop 1.5 support.
Realistically, it will be hard to remain on multiple Flink versions without
code diversion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 205685)
Time Spent: 1.5h (was: 1h 20m)
> Use Flink 1.6/1.7 prepareSnapshotPreBarrier to replace BufferedOutputManager
> ----------------------------------------------------------------------------
>
> Key: BEAM-6733
> URL: https://issues.apache.org/jira/browse/BEAM-6733
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Flink 1.6/1.7 provides a hook to execute an action before the snapshot
> barrier is emitted by the operator. At the moment (<=1.5) the Flink Runner
> has to buffer any elements which are emitted during a snapshot because the
> barrier has already been emitted. This leads to a lot of code complexity.
> We can remove the buffering in favor of finishing the current bundle in
> {{DoFnOperator}}'s {{prepareSnapshotPreBarrier}}. The 1.5/1.6/1.7 build setup
> poses a challenge to do that in a way that does not lead to much code
> duplication.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
