[
https://issues.apache.org/jira/browse/BEAM-8986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364456#comment-17364456
]
Kenneth Knowles commented on BEAM-8986:
---------------------------------------
This is a good point. From the point of view of Beam as a portable model, the
binary encoding is the only thing a runner "knows" about. So the necessary
property needs to be ensured in the coder. For example, the InstantCoder shifts
instants so that the encoded value is properly sorted.
This might be an important addition to the model, to define the needed property
of coders and have metadata to know if they have it.
> SortValues may not work correct for numerical types
> ---------------------------------------------------
>
> Key: BEAM-8986
> URL: https://issues.apache.org/jira/browse/BEAM-8986
> Project: Beam
> Issue Type: Bug
> Components: extensions-java-sorter
> Affects Versions: 2.16.0
> Reporter: Neville Li
> Priority: P1
> Labels: Clarified
>
> {{SortValues}} transform uses lexicographical on encoded binaries and may not
> work correctly if the encoding is inconsistent with native comparison, e.g.
> negative integers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
