[
https://issues.apache.org/jira/browse/BEAM-12514?focusedWorklogId=612144&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-612144
]
ASF GitHub Bot logged work on BEAM-12514:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/21 21:25
Start Date: 18/Jun/21 21:25
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #15040:
URL: https://github.com/apache/beam/pull/15040#issuecomment-864191990
#
[Codecov](https://codecov.io/gh/apache/beam/pull/15040?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#15040](https://codecov.io/gh/apache/beam/pull/15040?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(b19c53b) into
[master](https://codecov.io/gh/apache/beam/commit/000ac07f2883d4708b6abbfc935fd004405aae19?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(000ac07) will **increase** coverage by `1.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/15040?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15040 +/- ##
==========================================
+ Coverage 82.55% 83.75% +1.19%
==========================================
Files 455 439 -16
Lines 55143 59091 +3948
==========================================
+ Hits 45526 49494 +3968
+ Misses 9617 9597 -20
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/15040?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...python/apache\_beam/examples/wordcount\_dataframe.py](https://codecov.io/gh/apache/beam/pull/15040/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvd29yZGNvdW50X2RhdGFmcmFtZS5weQ==)
| `0.00% <0.00%> (-92.60%)` | :arrow_down: |
|
[...s/python/apache\_beam/examples/snippets/snippets.py](https://codecov.io/gh/apache/beam/pull/15040/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvc25pcHBldHMucHk=)
| `76.70% <0.00%> (-12.83%)` | :arrow_down: |
|
[sdks/python/apache\_beam/io/kafka.py](https://codecov.io/gh/apache/beam/pull/15040/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8va2Fma2EucHk=)
| `79.16% <0.00%> (-6.55%)` | :arrow_down: |
|
[sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/15040/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=)
| `87.80% <0.00%> (-5.06%)` | :arrow_down: |
|
[...n/apache\_beam/runners/direct/test\_direct\_runner.py](https://codecov.io/gh/apache/beam/pull/15040/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9kaXJlY3RfcnVubmVyLnB5)
| `37.50% <0.00%> (-4.81%)` | :arrow_down: |
|
[...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/15040/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5)
| `74.72% <0.00%> (-4.81%)` | :arrow_down: |
|
[test\_config.py](https://codecov.io/gh/apache/beam/pull/15040/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdF9jb25maWcucHk=)
| `66.66% <0.00%> (-4.77%)` | :arrow_down: |
|
[sdks/python/apache\_beam/runners/test/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/15040/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy90ZXN0L19faW5pdF9fLnB5)
| `66.66% <0.00%> (-4.77%)` | :arrow_down: |
|
[sdks/python/apache\_beam/io/gcp/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/15040/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL19faW5pdF9fLnB5)
| `80.00% <0.00%> (-4.62%)` | :arrow_down: |
|
[...thon/apache\_beam/runners/worker/channel\_factory.py](https://codecov.io/gh/apache/beam/pull/15040/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvY2hhbm5lbF9mYWN0b3J5LnB5)
| `75.00% <0.00%> (-3.95%)` | :arrow_down: |
| ... and [457
more](https://codecov.io/gh/apache/beam/pull/15040/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/15040?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/15040?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[9af555d...b19c53b](https://codecov.io/gh/apache/beam/pull/15040?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 612144)
Time Spent: 40m (was: 0.5h)
> BigQueryIO - ReadFromBigQuery can not get table reference from
> RuntimeValueProvider
> -----------------------------------------------------------------------------------
>
> Key: BEAM-12514
> URL: https://issues.apache.org/jira/browse/BEAM-12514
> Project: Beam
> Issue Type: Bug
> Components: io-py-gcp
> Affects Versions: 2.26.0, 2.27.0, 2.28.0, 2.29.0, 2.30.0
> Reporter: Teng Qiu
> Priority: P2
> Labels: GCP, pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> After this
> [change|https://github.com/apache/beam/commit/1a08c01ab1cadec16cc13866d5e6c64f6b447b03#diff-0c77ebbb0792b80a76f4ec1f2b89b9d319f5e33f1ee0857ed6fe414f75c48cbbR746],
> the table reference couldn't be parsed correctly when {{ReadFromBigQuery}}
> is taking a {{RuntimeValueProvider}} as value of table.
> This bug is included since v2.26.0
>
> Code to reproduce:
> {code:python}
> import apache_beam as beam
> from apache_beam.options.pipeline_options import PipelineOptions
> class MyOptions(PipelineOptions):
> @classmethod
> def _add_argparse_args(cls, parser):
> parser.add_value_provider_argument(
> "--input",
> type=str,
> default='test-project:test_dataset.test_table',
> )
> pipeline_options = PipelineOptions()
> with beam.Pipeline(options=pipeline_options) as p:
> my_options = pipeline_options.view_as(MyOptions)
> lines = p | "read" >> beam.io.ReadFromBigQuery(table=my_options.input)
> row_count = lines | "count" >> beam.combiners.Count.Globally()
> row_count | beam.Map(print)
> p.run().wait_until_finish()
> {code}
> Error message will be:
> {noformat}
> Traceback (most recent call last):
> ..
> ..
> File
> "....../venv/lib/python3.8/site-packages/apache_beam/io/gcp/bigquery.py",
> line 722, in estimate_size
> if not table_ref.projectId:
> AttributeError: 'RuntimeValueProvider' object has no attribute 'projectId'
> [while running
> 'read/Read/SDFBoundedSourceReader/ParDo(SDFBoundedSourceDoFn)/SplitAndSizeRestriction']
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
