[
https://issues.apache.org/jira/browse/BEAM-11994?focusedWorklogId=612891&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-612891
]
ASF GitHub Bot logged work on BEAM-11994:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/21 22:16
Start Date: 21/Jun/21 22:16
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #14805:
URL: https://github.com/apache/beam/pull/14805#discussion_r655739325
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java
##########
@@ -262,6 +265,8 @@ public static void main(
}
});
+ MetricsEnvironment.setProcessWideContainer(new MetricsContainerImpl());
Review comment:
My preference is to have the tests be non-idiomatic (e.g. you could have
a reset-process-container-for-test method) than have the "production" code be
non-idiomatic to accommodate tests. Having a setter doesn't prevent state from
leaking from test to test (though I guess it forces you to set it in at least
one test).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 612891)
Time Spent: 17h 40m (was: 17.5h)
> Java BigQuery - Implement IO Request Count metrics
> --------------------------------------------------
>
> Key: BEAM-11994
> URL: https://issues.apache.org/jira/browse/BEAM-11994
> Project: Beam
> Issue Type: Test
> Components: io-java-gcp
> Reporter: Alex Amato
> Assignee: Alex Amato
> Priority: P2
> Time Spent: 17h 40m
> Remaining Estimate: 0h
>
> Reference PRs (See BigQuery IO example) and detailed explanation of what's
> needed to instrument this IO with Request Count metrics is found in this
> handoff doc:
> [https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'|https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'?authuser=0]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
