[
https://issues.apache.org/jira/browse/BEAM-12528?focusedWorklogId=613704&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-613704
]
ASF GitHub Bot logged work on BEAM-12528:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/21 21:16
Start Date: 22/Jun/21 21:16
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #15066:
URL: https://github.com/apache/beam/pull/15066#issuecomment-866339465
R: @lukecwik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 613704)
Time Spent: 20m (was: 10m)
> Don't reuse failed plans.
> -------------------------
>
> Key: BEAM-12528
> URL: https://issues.apache.org/jira/browse/BEAM-12528
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Failed plans get re-appended to the list of plans unconditionally.
>
> [https://github.com/apache/beam/blob/cf8ffe660cfcb1f7d421171f406fa991b93e043b/sdks/go/pkg/beam/core/runtime/harness/harness.go#L315]
>
> Which means there's a risk that a new bundle using the same bundle descriptor
> might re-use a failed plan.
>
> [https://github.com/apache/beam/blob/cf8ffe660cfcb1f7d421171f406fa991b93e043b/sdks/go/pkg/beam/core/runtime/harness/harness.go#L236]
>
> While users should be resetting everything in StartBundle, that's not
> necessarily the case. It would be easier on users when plans are re-used to
> recreate them on failures.
>
> After a certain point plans are garbage collected already, both failed and
> successful.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
