[ 
https://issues.apache.org/jira/browse/BEAM-12532?focusedWorklogId=614755&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614755
 ]

ASF GitHub Bot logged work on BEAM-12532:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Jun/21 22:59
            Start Date: 24/Jun/21 22:59
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on pull request #15070:
URL: https://github.com/apache/beam/pull/15070#issuecomment-868014103


   Please run `./gradlew spotlessApply` to fix up formatting and push up the 
formatting fixes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 614755)
    Time Spent: 1h 10m  (was: 1h)

> BigQueryUtils fromBeamField omits ":00" from times with 0 seconds
> -----------------------------------------------------------------
>
>                 Key: BEAM-12532
>                 URL: https://issues.apache.org/jira/browse/BEAM-12532
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp
>    Affects Versions: 2.30.0
>            Reporter: Matthew Ouyang
>            Assignee: Matthew Ouyang
>            Priority: P2
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> If a value in a Beam Row is of the SqlTypes.TIME data type, BigQueryUtils 
> uses `toString()` to print out the time value [1].  `toString()` tries to 
> optimize the string length by omitting nanoseconds if it is zero, and seconds 
> if it is also zero [2].  However the BigQuery time type requires seconds to 
> always be there even if it's zero [3].
> [1] 
> https://github.com/apache/beam/blob/58e2ea9c40fd08e24f23183852970f566b17d6cd/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java#L551
> [2] 
> https://docs.oracle.com/javase/8/docs/api/java/time/LocalTime.html#toString--
> [3] 
> https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#time_type



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to