[ 
https://issues.apache.org/jira/browse/BEAM-6175?focusedWorklogId=206332&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-206332
 ]

ASF GitHub Bot logged work on BEAM-6175:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Mar/19 09:44
            Start Date: 01/Mar/19 09:44
    Worklog Time Spent: 10m 
      Work Description: kkucharc commented on issue #7965: [BEAM-6175] Extract 
reader and publisher from MetricsMonitor in Python load tests
URL: https://github.com/apache/beam/pull/7965#issuecomment-468605993
 
 
   retest this please
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 206332)
    Time Spent: 40m  (was: 0.5h)

> Extract reader and publisher from MetricsMonitor in Python Load Test utils
> --------------------------------------------------------------------------
>
>                 Key: BEAM-6175
>                 URL: https://issues.apache.org/jira/browse/BEAM-6175
>             Project: Beam
>          Issue Type: Improvement
>          Components: testing
>            Reporter: Kasia Kucharczyk
>            Assignee: Kasia Kucharczyk
>            Priority: Minor
>              Labels: triaged
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> For load tests metrics (load_test_utils.py) flexibility purposes, two classes 
> should be extracted from MetricsMonitor class:
> * MetricsReader - will only query the metrics by specific names/namespaces 
> and return a Map of keys and metric values for a namespace
> * MetricsPublisher - as a set of "Publishers". Each publisher then could 
> publish() to separate medium (BigQueryClient/console/others)
> This would make it even easier to extend this code in the future.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to